Skip to content

Get some Unit Tests and CI #11

Open

Description

@ccoffrin

I could use some help. I have no idea how to test JS.

Activity

  1. changed the title [-]Get some Unit Tests and CI on this repo...[/-] [+]Get some Unit Tests and CI[/+] on Aug 12, 2016
  2. Bluejay47 commented on Sep 3, 2016

    @Bluejay47

    I use Mocha but there are several other popular unit test systems. What did you have in mind as far as priorities for developing tests?

  3. ccoffrin commented on Sep 3, 2016

    @ccoffrin
    MemberAuthor

    Nothing too major. In other code bases I try make some easy integration tests that emulate typical student interactions. Then use code coverage reports to make sure I have hit 80-90% of the code.

    This is a good example,

    https://github.com/discreteoptimization/assignment/blob/master/test/submit_test.py

    I no nothing about JS unit testing frameworks or how to do CI outside the browser, so your experience would be much appreciated!

  4. Bluejay47 commented on Sep 6, 2016

    @Bluejay47

    Sure I can take a stab at it this weekend. Setting up the framework is fairly easy and Mocha is very straightforward.

  5. Bluejay47 commented on Sep 13, 2016

    @Bluejay47

    I am using mocha.js for testing and blanketjs for code coverage. Do you have a preference as to how to include these in the project? Do you want to continue to load external libraries from a CDN or would you prefer to move these libraries into the project using Bower?

  6. ccoffrin commented on Sep 17, 2016

    @ccoffrin
    MemberAuthor

    In light of modern web tools, I am a web-dev novice; so I'll trust your judgement on this one.

    My feeling is that it is best to load the libraries via a CDN. That way, it is one less tool that a would-be contributor would need to learn.

    These are not mission critical tools so if the break due to an external library update that is not a huge deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions