Skip to content

Solver java fixed - #33

Merged
ccoffrin merged 1 commit into
discreteoptimization:masterfrom
luckman:master
May 13, 2017
Merged

ccoffrin merged 1 commit into
discreteoptimization:masterfrom
luckman:master

Conversation

@luckman

@luckman luckman commented May 13, 2017

Copy link
Copy Markdown
Contributor

@codecov-io

codecov-io commented May 13, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          17       17           
  Lines        1056     1056           
=======================================
  Hits          945      945           
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf50cd...6c1047d. Read the comment docs.

@ccoffrin

Copy link
Copy Markdown
Member

Looks good. Thanks!

Out of curiosity, on which platform was there an issue that universal_newlines fixed?

@luckman

luckman commented May 13, 2017

Copy link
Copy Markdown
Contributor Author

I faced an issue with default java solver on my Windows 7 64-bit

Java stdout was String
18 0
1 1 0 0

(or "18 0\n1 1 0 0")

Result of the scripts looks like
b'18 0\r\n1 1 0 0'

@ccoffrin

Copy link
Copy Markdown
Member

k, thanks!

@ccoffrin
ccoffrin merged commit b04d42f into discreteoptimization:master May 13, 2017
@ccoffrin ccoffrin mentioned this pull request May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants