Repository navigation
Solver java fixed - #33
Merged
Merged
Conversation
luckman
commented
May 13, 2017
Contributor
- Universal new lines (see https://www.coursera.org/learn/discrete-optimization/discussions/all/threads/qsGQMI_FEeaEMQ4qyS4RFQ)
- print command fixed
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 17 17
Lines 1056 1056
=======================================
Hits 945 945
Misses 111 111Continue to review full report at Codecov.
|
Member
|
Looks good. Thanks! Out of curiosity, on which platform was there an issue that universal_newlines fixed? |
Contributor
Author
|
I faced an issue with default java solver on my Windows 7 64-bit Java stdout was String (or "18 0\n1 1 0 0") Result of the scripts looks like |
Member
|
k, thanks! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.