Repository navigation
Conversation
Defer frame buffers and metrics until after the BWAPI handshake, and use a focused Windows shared-memory mapping interface. Automatically load an architecture-named JNA DLL beside the bot JAR after verifying it against the embedded binary. Preserve explicit JNA settings and ordinary loading when no matching bundle is available, without a custom native cache. Package portable Windows DLLs beside the JAR and cover native loading, startup ordering, mapping behavior, and Windows Java 8 x86 in tests and CI.
…moved unused imports.
dgant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stash of my local changes. Not intended to be upstreamed.
Agent wrote:
Port the remaining PurpleWave connection and map-access extensions onto JavaBWAPI/JBWAPI develop at 0507796. The fork's develop branch now contains the rebased connection-readiness work, including optional adjacent JNA DLL loading and the ordinary JNA fallback. No custom native cache is included.
This branch preserves unchecked visibility/exploration/creep queries and explicit bwapi.serverProcessId selection, moves null-mapping diagnostics into the upstream Windows connector, and rejects nonpositive process IDs when no automatic server is available. New regression tests cover process selection, missing servers, and live map data.
Validation:
Windows Java 8u171 x86: 58 JBWAPI tests, zero failures/errors, one intentionally skipped non-Windows-only test (bundledWindowsLibrariesAreIgnoredOnOtherPlatforms); that test passes in Linux CI.
PurpleWave compiled successfully with JNA 5.18.1 and the upstream configuration builder/POSIX dependencies.
A complete SC-Docker game against Stardust on Fighting Spirit (seed 1101) ended normally, with no crash or game/realtime timeout; both replays were recorded. PurpleWave lost the game.
Combined integration with the query-cache and walkability branches: 74 JBWAPI tests, zero failures/errors, the same single skip, plus another complete game.
The PurpleWave integration follow-up repairs stale strategy expectations and test fixtures; the proxy strategy, Carrier reserve, Dark Templar defense, and gathering checks now pass against the tested combined bot.
The tested code was rebased once more solely to include the measured timing comment requested in upstream PR JavaBWAPI#97; the runtime implementation is unchanged.