Repository navigation
feat!: change default plugin dir - #1004
Merged
Merged
Conversation
iyear
force-pushed
the
change-default-plugin-dir
branch
2 times, most recently
from
August 18, 2022 07:51
4465680 to
003c09c
Compare
Signed-off-by: iyear <ljyngup@gmail.com>
Signed-off-by: iyear <ljyngup@gmail.com>
iyear
force-pushed
the
change-default-plugin-dir
branch
from
August 18, 2022 07:59
003c09c to
024d1dd
Compare
Member
Author
|
@devstream-io/reviewer New Behavioronly set flag:
only set config:
default value:
set both flag and config(flag has higher priority):
actions-test: |
daniel-hutao
self-requested a review
August 18, 2022 08:19
daniel-hutao
requested changes
Aug 18, 2022
daniel-hutao
left a comment
daniel-hutao
left a comment
Member
There was a problem hiding this comment.
Good job!
Please test this pr fully, as it is a very basic feature, to avoid introducing more serious bugs.
Signed-off-by: iyear <ljyngup@gmail.com>
iyear
force-pushed
the
change-default-plugin-dir
branch
from
August 18, 2022 08:43
acd945b to
9c9aff9
Compare
daniel-hutao
approved these changes
Aug 18, 2022
steinliber
approved these changes
Aug 19, 2022
IronCore864
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iyear ljyngup@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
A simpler solution to the plugin absolute path problem that does not affect documentation.
The only impact is that the developer needs to specify
-d .devstreamwhen debugging the plugin.Related Issues
close #997
New Behavior (screenshots if needed)
The plugin version shown is for demonstration purposes only, not the actual situation.