Skip to content

🍀 Proposal: Refactor downloaders #1165

Closed

Description

@aFlyBird0

What Would You Like to Add? Why Is This Needed?

There are too many downloaders in devstream. We should unify them.

  1. (unused)
    type DownloadClient struct {
  2. type PbDownloadClient struct {
  3. func Download(url, filename, targetDir string) (int64, error) {

Design

Add a new downloader and put it into pkg/util/downloader, and the process bar should be optional.

Anything else

Activity

  1. self-assigned this
    on Oct 11, 2022
  2. changed the title [-]:four_leaf_clover: `Proposal`: [/-] [+]:four_leaf_clover: `Proposal`: Refactor downloaders[/+] on Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions