🍀 Proposal: Add process bar during dtm upgrade

What Would You Like to Add? Why Is This Needed?

devstream/internal/pkg/upgrade/upgrade.go

Lines 88 to 92 in e07a621

    
           // TODO(hxcGit): add download progress bar 
        
           if err = ghClient.DownloadAsset(ltstReleaseTagName, assetName, dtmTmpFileName); err != nil { 
        
           	log.Debugf("Failed to download dtm: %v-%v.", ltstReleaseTagName, assetName) 
        
           	return err 
        
           }

Design

We could just refactor this function:

devstream/pkg/util/scm/github/download.go

Line 13 in e07a621

func (c *Client) DownloadAsset(tagName, assetName, fileName string) error {

Maybe you could focus on these code:

devstream/pkg/util/scm/github/download.go

Lines 49 to 68 in e07a621

    
           var downloadUrl string 
        
           for _, a := range assets { 
        
           	if a.GetName() == assetName { 
        
           		downloadUrl = a.GetBrowserDownloadURL() 
        
           		log.Debugf("Download url: %s.", downloadUrl) 
        
           		break 
        
           	} 
        
           } 
        
           if downloadUrl == "" { 
        
           	log.Debugf("Failed to got the download url for %s, maybe it not exists.", assetName) 
        
           	return fmt.Errorf("failed to got the download url for %s, maybe it not exists", assetName) 
        
           } 
        
           // 4. download 
        
           n, err := downloader.Download(downloadUrl, fileName, c.WorkPath) 
        
           if err != nil { 
        
           	log.Debugf("Failed to download asset from %s.", downloadUrl) 
        
           	return err 
        
           } 
        
           log.Debugf("Downloaded <%d> bytes.", n)

In line 63, now we use downloader.Download which doesn't support process bar.
Therefore, you should refactor the function or create a new function to support process bar.

I guess this function can help you.

devstream/internal/pkg/pluginmanager/pbdownloader.go

Lines 85 to 107 in e07a621

    
           func setUpProgressBar(resp *http.Response, downFile *os.File) error { 
        
           	//get size 
        
           	i, _ := strconv.Atoi(resp.Header.Get("Content-Length")) 
        
           	sourceSiz := int64(i) 
        
           	source := resp.Body 
        
           	//create a bar and set param 
        
           	bar := pb.New(int(sourceSiz)).SetRefreshRate(time.Millisecond * 10).SetUnits(pb.U_BYTES).SetWidth(100) 
        
           	bar.ShowSpeed = true 
        
           	bar.ShowTimeLeft = true 
        
           	bar.ShowFinalTime = true 
        
           	bar.SetWidth(80) 
        
           	bar.Start() 
        
           	writer := io.MultiWriter(downFile, bar) 
        
           	_, err := io.Copy(writer, source) 
        
           	if err != nil { 
        
           		log.Error(err) 
        
           		return err 
        
           	} 
        
           	bar.Finish() 
        
           	return nil 
        
           }

Anything else

Please be brave to do some refactors. e.g. Maybe you will use setUpProgressBar which is in pluginmanager pkg and it is an unexported function. So, it is ok to change its place and export it.

Maybe I can have a try.

@CrazyCollin

Maybe I can have a try.

Hi, @CrazyCollin, the issues marked with the "good first issue" label are intended for first-time contributors. Let's save the remaining "good first issue" items for other new contributors.

Feel so sorry, I'll pay attention next time.

I want to work on this.

Navigation Menu

Repository navigation

🍀 `Proposal`: Add process bar during `dtm upgrade` #1146

What Would You Like to Add? Why Is This Needed?

Design

Anything else

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// TODO(hxcGit): add download progress bar
	if err = ghClient.DownloadAsset(ltstReleaseTagName, assetName, dtmTmpFileName); err != nil {
	log.Debugf("Failed to download dtm: %v-%v.", ltstReleaseTagName, assetName)
	return err
	}

	var downloadUrl string
	for _, a := range assets {
	if a.GetName() == assetName {
	downloadUrl = a.GetBrowserDownloadURL()
	log.Debugf("Download url: %s.", downloadUrl)
	break
	}
	}
	if downloadUrl == "" {
	log.Debugf("Failed to got the download url for %s, maybe it not exists.", assetName)
	return fmt.Errorf("failed to got the download url for %s, maybe it not exists", assetName)
	}

	// 4. download
	n, err := downloader.Download(downloadUrl, fileName, c.WorkPath)
	if err != nil {
	log.Debugf("Failed to download asset from %s.", downloadUrl)
	return err
	}
	log.Debugf("Downloaded <%d> bytes.", n)

	func setUpProgressBar(resp http.Response, downFile os.File) error {
	//get size
	i, _ := strconv.Atoi(resp.Header.Get("Content-Length"))
	sourceSiz := int64(i)
	source := resp.Body

	//create a bar and set param
	bar := pb.New(int(sourceSiz)).SetRefreshRate(time.Millisecond * 10).SetUnits(pb.U_BYTES).SetWidth(100)
	bar.ShowSpeed = true
	bar.ShowTimeLeft = true
	bar.ShowFinalTime = true
	bar.SetWidth(80)
	bar.Start()

	writer := io.MultiWriter(downFile, bar)
	_, err := io.Copy(writer, source)
	if err != nil {
	log.Error(err)
	return err
	}
	bar.Finish()
	return nil
	}

🍀 Proposal: Add process bar during dtm upgrade #1146

Description

What Would You Like to Add? Why Is This Needed?

Design

Anything else

Activity

CrazyCollin commented on Oct 2, 2022

daniel-hutao commented on Oct 6, 2022

CrazyCollin commented on Oct 6, 2022

0zyt commented on Oct 7, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

🍀 `Proposal`: Add process bar during `dtm upgrade` #1146