Skip to content

🍀 Proposal: Automatically detect binary filenames on dtm upgrade #1110

Closed
Closed
🍀 Proposal: Automatically detect binary filenames on dtm upgrade#1110
Assignees
CrazyCollin
Labels
good first issueGood for newcomers

Description

@aFlyBird0
aFlyBird0
opened on Sep 21, 2022

What Would You Like to Add? Why Is This Needed?

When I executed dtm upgrade, an error occurred.

image

Because now the name of dtm binary is hard coded to "dtm".

devstream/internal/pkg/upgrade/upgrade.go

Line 20 in e13f336

dtmFileName = "dtm"

devstream/internal/pkg/upgrade/upgrade.go

Lines 123 to 155 in e13f336

// applyUpgrade use os.Rename replace old version dtm with the latest one
// (1) rename `dtm` to `dtm-bak`.
// (2) rename `dtm-tmp` to `dtm`.
// (3) grant new `dtm` execute permission.
// (4) remove `dtm-bak` binary file.
// TODO(hxcGit): Support for rollback in case of error in intermediate steps
func applyUpgrade(workDir string) error {
dtmFilePath := filepath.Join(workDir, dtmFileName)
dtmBakFilePath := filepath.Join(workDir, dtmBakFileName)
dtmTmpFilePath := filepath.Join(workDir, dtmTmpFileName)
if err := os.Rename(dtmFilePath, dtmBakFilePath); err != nil {
return err
}
log.Debug("Dtm upgrade: rename dtm to dtm-bak successfully.")
if err := os.Rename(dtmTmpFilePath, dtmFilePath); err != nil {
return err
}
log.Debug("Dtm upgrade: rename dtm-tmp to dtm successfully.")
if err := os.Chmod(dtmFilePath, 0755); err != nil {
return err
}
log.Debug("Dtm upgrade: grant dtm execute permission successfully.")
if err := os.Remove(dtmBakFilePath); err != nil {
return err
}
log.Debug("Dtm upgrade: remove dtm-bak successfully.")
return nil
}

If the binary name is not "dtm", such as "dtm-darwin-arm64", it will occur an error.

Design

We should be should to automatically detect binary filenames.

Note: you can use os.Executable() to get the binary path.

Anything else

Don't forget to update related code comments.

Happy coding!

Activity

  1. aFlyBird0
    added
    good first issueGood for newcomers
    on Sep 21, 2022

  2. CrazyCollin commented on Sep 23, 2022

    @CrazyCollin
    CrazyCollin
    on Sep 23, 2022

    Hi,@aFlyBird0, I wanna have a try, plz assign to me.

  3. daniel-hutao
    assigned
    CrazyCollin
    on Sep 29, 2022

  4. daniel-hutao commented on Sep 29, 2022

    @daniel-hutao
    daniel-hutao
    on Sep 29, 2022
    Member

    /assign @CrazyCollin

  5. daniel-hutao
    closed this as completedon Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions