Skip to content

Functions that construct the database should check for errors #29

Open
Open
Functions that construct the database should check for errors#29

Description

@MrMino
MrMino
opened on Mar 2, 2019

TIL that in my environment, if I install pyscope, the pyscope command is not available pycscope != pyscope. This meant, that if I tried to create the database, the command in vim would show success, yet only .files file would be created.

It would be nice if a failure message would be shown instead of "yay, success" one :).

Activity

  1. devjoe commented on Mar 17, 2019

    @devjoe
    devjoe
    on Mar 17, 2019
    Owner

    @MrMino I got your point, thanks for your suggestion. I hope I will have time to tweak these two functions 😹:

    function! codequery#db#make_db_callback(job, status) dict
    echom 'Done!  (' . self.db_path . ')'
endfunction

function! codequery#db#make_db_nvim_callback(job, data, status) dict
    echom 'Done! Built codequery db!'
endfunction```

If you can help, PR is welcome~

  2. MrMino commented on Mar 18, 2019

    @MrMino
    MrMino
    on Mar 18, 2019
    Author

    I'd love to send a PR for this, but I'm not very well versed in developing in vimscript. We'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions