Repository navigation
Apply Git clean filters to working-tree files - #61
Merged
Merged
Conversation
Working-tree sides were read as raw bytes, so under core.autocrlf a CRLF checkout compared against LF blobs. Plain-text files (e.g. Markdown) then showed every line as changed.
sidkmenon
approved these changes
Sep 30, 2026
sidkmenon
approved these changes
Sep 30, 2026
thesiti92
enabled auto-merge (squash)
September 30, 2026 19:42
This was referenced Sep 30, 2026
Merged
thesiti92
added a commit
to devdotfast/whiteboard
that referenced
this pull request
Sep 30, 2026
Fixes #805. diffr 0.1.8 (devdotfast/diffr#61) reads working-tree files through Git's clean filters. Under `core.autocrlf=true`, a CRLF checkout was compared raw against LF blobs, so plain-text files such as Markdown showed every line as changed. - Pin `@dev.fast/diffr` 0.1.8 in Review, Desktop and review-protocol; update the lockfile and release-age exception. - diffr 0.1.8 removed `--config`: the summarizer test writes `diffr/config.toml` under a temp dir and sets `XDG_CONFIG_HOME` to it. The fake diffr in `diffr-config.test.ts` follows. Validation: - Issue repro through `structuralDiff` (worktree comparison): `notes.md` 200/200 changed lines on 0.1.7, 0 lhs / 1 rhs on 0.1.8; right side no longer carries `\r`. - 14 bundled-diffr integration tests against the fetched 0.1.8 release; review-protocol tests (59); diffr-config and structural-diff tests; root lint and format; typecheck for review, review app and review-protocol; Desktop protocol sync unchanged. - No native Desktop UI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working-tree sides were read as raw bytes, so with
core.autocrlf=truea CRLF checkout was compared against LF blobs. Tree-sitter languages hid it (atoms drop\r), but plain-text files such as Markdown fell back to the line diff and showed every line as changed (devdotfast/whiteboard#805).Working-tree files now go through libgit2's
blob_path, which applies Git's clean filters (autocrlf, eol, ident) likegit diff. A mempack backend on the session repository keeps those blobs out of.git/objects.tests/view.rs: autocrlf repo, CRLF Markdown working copy, one line changed.