This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
Remove the --config flag - #56
Merged
Merged
Conversation
Behavior change (with the next commit): Config::load no longer takes an explicit path; it reads $XDG_CONFIG_HOME/diffr/config.toml, a missing file being the defaults. The file-reading half becomes load_from, which the unit tests call directly. AI assistance: Claude Code. Agent-Session: b28d94c6-2325-41ab-9fab-e9027acc5b09 Agent-Session: 01a0e9c2-2c41-7062-b484-92e030c4ab9c
Behavior change: `--config PATH` is now an unknown argument, and `config set` always writes the global file. Only tests used the flag: the settings screen always edits the global file, and XDG_CONFIG_HOME already points diffr at another config home. AI assistance: Claude Code. Agent-Session: b28d94c6-2325-41ab-9fab-e9027acc5b09 Agent-Session: 01a0e9c2-2c41-7062-b484-92e030c4ab9c
No behavior change. Each test writes its config as <home>/diffr/config.toml and sets XDG_CONFIG_HOME to <home>, as tests/view.rs already does. Relative plugin paths still resolve against the file's own folder. AI assistance: Claude Code. Agent-Session: b28d94c6-2325-41ab-9fab-e9027acc5b09 Agent-Session: 01a0e9c2-2c41-7062-b484-92e030c4ab9c
AI assistance: Claude Code. Agent-Session: b28d94c6-2325-41ab-9fab-e9027acc5b09 Agent-Session: 01a0e9c2-2c41-7062-b484-92e030c4ab9c
sidkmenon
added this pull request to stack #59
September 30, 2026 16:28
sidkmenon
marked this pull request as ready for review
September 30, 2026 17:11
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬