Skip to content

Acquire devcontainer CLI and shell out to shared operations - #42

Merged
joshspicer merged 9 commits into
mainfrom
jospicer/consume-devcontainer-cli
Aug 17, 2022
Merged

joshspicer merged 9 commits into
mainfrom
jospicer/consume-devcontainer-cli

Conversation

@joshspicer

@joshspicer joshspicer commented Aug 16, 2022 •

Copy link
Copy Markdown
Contributor

related to https://github.com/github/codespaces/issues/9301

  • Add the ability to detect whether the devcontainer cli is installed, and if not fetch the latest release from npm
  • Shells out to the devcontainer features publish ... command
  • Removes old code related to packaging. That will be handled by the devcontainer CLI moving forward
  • Removes several unneeded dependencies and regenerate lock file (to resolve all pending dependabot)

Example test run: https://github.com/codspace/yet-another-features-mirror/runs/7865685664?check_suite_focus=true . Note that for this example, a custom build of the CLI is being used in this test run that includes devcontainers/cli#97

@joshspicer joshspicer self-assigned this Aug 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM, approved with suggestions.

Comment thread src/generateDocs.ts Resolved
Comment thread action.yml Resolved
Comment thread src/utils.ts Resolved
@joshspicer
joshspicer merged commit 575415d into main Aug 17, 2022
@joshspicer
joshspicer deleted the jospicer/consume-devcontainer-cli branch August 17, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants