Repository navigation
Give decisions/M1, M3 and M4 a Standing block (#762) - #814
Merged
Merged
Conversation
Each file gains a ## Standing index and a ## Log heading, and leaves decisions_without_standing.json. Heads reversed in part elsewhere gain edit-kind-1 notes (#601, #653, #434, M3's opt-in narrowing). rules/M3's Accepted contrast used 'Jane Smith née V', which reads maiden 'V' bare too since #601; the contrast is now shown with PhD. The pointer resolver refused twin heads beside a head of the same date and issue that continues past them (M3's and M4's #335/#445 entries); twin keys now resolve there, with test rows for both directions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1PNxBYs77bSguGoJruCvd
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1PNxBYs77bSguGoJruCvd
- Not standing: pointers naming more than one entry now fail as ambiguous, as Standing pointers do; the wider twin resolution had let a typo'd key there pass silently. - rules/M3's Accepted bullet shows its contrast with PhD alone; the (née V) row moves to the main fence, where its reading still holds. - M1's Not-standing line no longer points at a standing entry. - M3 and M4 lines scope their order-dependent fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1PNxBYs77bSguGoJruCvd
- Scope the remaining order-dependent fields in M3 and M4. - Note in M3's #335 accepted-consequence head that rules/M3's Accepted witness is (née PhD) now. - standing_findings' docstring and the decisions README say what a Not standing: pointer is checked for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1PNxBYs77bSguGoJruCvd
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4659 4659
=======================================
Hits 4615 4615
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…tion # Conflicts: # tests/v2/decisions_without_standing.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #762. M2 (20 entries) is left for its own batch; lines that rest on an M2 decision point there with
Elsewhere:.What changes
Not standing:,Elsewhere:andOpen:lines and a## Logheading. All three are taken offtests/v2/decisions_without_standing.json.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 entry.maidenkeeps its marker where the bare form drops it ((née Jones)vsnée Jones) #329: the "multi-word clause" condition and the "clause-size guard", corrected by parse("Maria Kowalska z domu Nowak") cannot reach the Polish maiden marker — markers do not compose the way suffixes do #434.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 accepted-consequence: the barenée Vcontrast, changed by M2's Rethink the maiden-marker rule (M2): a marker stands after the current name and takes words up to the trailing suffix run #601.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 implemented-list:_extract.pyalone, extended by A nickname loses its comma:Jane (Janey, Jo) Smithgives nicknameJaney Jo(1.4.0:Janey, Jo) #653.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 durable-finding: the comma witness, moved by A nickname loses its comma:Jane (Janey, Jo) Smithgives nicknameJaney Jo(1.4.0:Janey, Jo) #653.'Smitty' Jones Jr. née Smithwitness, changed by Rethink the maiden-marker rule (M2): a marker stands after the current name and takes words up to the trailing suffix run #601.Jane Smith (née V)against the bareJane Smith née V, but since Rethink the maiden-marker rule (M2): a marker stands after the current name and takes words up to the trailing suffix run #601 (decisions/M2) the bare spelling reads maiden 'V' too. The contrast is nowJane Smith (née PhD)→ maiden 'PhD' againstJane Smith née PhD→ suffix 'PhD'. The(née V)row moves to the main fence, where its reading still holds.corpus_rules.jsonlandsnapshot.jsonlgain the two new names and nothing else moves.tests/v2/design_docs.py).2026-08-26 #335,2026-08-27 #445) beside one head with that date and issue that goes on longer (#335 (M3, PR on …)). The resolver refused to resolve those twin heads by their text key; it now does.Not standing:pointers that name more than one entry now fail as ambiguous, as Standing pointers already did.test_design_docs.pycover both directions. The README and thestanding_findingsdocstring say what is checked.Verification
Policy(maiden_delimiters=frozenset({("(", ")")}))where it matters.ruffandmypyare clean.Review findings (two
design-docs-reviewerrounds, both fixed)Round 1:
Not standing:line pass silently, because that branch never checked for ambiguity. It now fails, and has test rows.(née V)as a bracketed-versus-bare contrast. Fixed as described above.2026-08-26 #335 (M3)entry. It now names Parenthesized(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 in prose.abd née Jones,j nee smith,Jane Smith (née Jr.),Jane Smith née PhD). They are now scoped to the default order.Round 2, on the fix commit:
Jane (née Jones) Smith,Rosalind Roz Smith,'Smitty' Jones Jr. née Smith. Scoped.standing_findingsdocstring and the README's## Standingbullet did not say what a Not-standing pointer is checked for. Both now do.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 accepted-consequence head now says the Accepted witness is(née PhD).Stale, found and left
nameparser/_policy.py'sapply_patchdocstring says the maiden-wins canonicalization was "decided 2026-07-19". decisions/M1's entry and commit cc7063f both say 2026-07-18, "ruled the same day". I didn't resolve which date is right.(née Jones)parses as a nickname where the barenée Jonesgives maiden #335 gate-visibility entries). The decisions themselves still hold, so the entries are left as written, withNot standing:lines where an entry was only about the gates.Not merging; Derek decides.
Generated by Claude Code