Repository navigation
Repair a joined acronym credential as one word (#808) - #812
Merged
Merged
Conversation
…#808) A listed acronym credential holding a hyphen or slash (otr/l, fnp-bc, kchs/dchs) was split by the per-word walk and each side capitalized as a name part: 'Otr/L'. In the suffix role the whole token now repairs in capitals, and a recorded casing is laid over the whole token in any role (it was silently dropped before). Hyphenated names and titles are untouched. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4659 +17
=======================================
+ Hits 4598 4615 +17
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Review of #812 found that dropping either gate of _joined_whole passed the suite. Add rows for a listed joined acronym in a name role, an unlisted joined word in the suffix role, the comma shapes and family-first order, and a mask in a non-suffix role and on a dotted key; correct the decisions entry's claim about pa-c (2.0.0 through 2.5.0 gave Pa-C) and a stale test docstring. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #808.
A listed acronym credential joined by a hyphen or slash was split by case repair's per-word walk and each side capitalized as a name part:
john smith, kchs/dchsgaveKchs/Dchs,ccc/slpgaveCcc/Slp. (pa-conly looked right because both halves happen to capitalize correctly.)OTR/L,FNP-BC,KCHS/DCHS).Smith-Jones,Jean-Luc,da-Silva), hyphenated titles (Dipl.-Ing) and mixed-case input (R5's gate) are unchanged.Docs: rules/R4 gains fix and boundary rows, decisions/R4 a dated entry, and the 2.6.0 release log a bullet (checked against the 2.0.0, 2.4.2 and 2.5.0 wheels).
capitalized()is invisible to the snapshot, so no count is claimed.rules_budget.json,corpus_rules.jsonlandsnapshot.jsonlare re-recorded (the snapshot gains only the new example names).Test plan: full suite (22,659 passed),
ruff,mypy, and both Sphinx builds are clean. Three tests pin the repair (test_a_joined_acronym_repairs_whole_and_a_recorded_casing_wins,..._is_capitals_only_as_a_listed_suffix,test_a_recorded_casing_reaches_a_joined_token_in_any_role); each gate (mask, vocabulary, suffix role) fails a test when removed. Not run: the Python 3.15 interpreter check.🤖 Generated with Claude Code