Conversation
…past the second comma (#603) C1: where the first suffix word of the part after the comma, with only titles in front of it, starts S2's run, every word after it reads as that run reads -- a title word as a title, anything else as a suffix -- so 'John Smith, PhD Jones' is given John, family Smith, suffix 'PhD Jones', and with one word before the comma the whole part is suffixes ('Doe, PhD Jones', Derek's call over a credential-then-given reading). It extends #296's no-name-word reading in segment_suffix_reading rather than adding a structure: a title/suffix dual opens the part only behind two name words (assign's shared full_name count) and never in front of paired initials, dotted or two capitals. Absorbed name words report suffix-or-name, as #602's run's do. starts_a_credential_run now accepts the merged 'Ph. D.' piece, so the split spelling starts both runs ('Smith, John Ph. D. Jones' kept middle 'Jones'); AGENTS.md's spelling sweep records it. C2: a title word in a part past the second comma that is not also a suffix word is a title ('Eric H. Holder, Jr., Attorney General'), and a part of title and suffix words is not flagged; asked word by word, so a connective-joined title keeps the flag. Seven corpus names move, all intended; 619 of 97,881 generated texts, all in these shapes. Ledgers classify both rules at every baseline (the 1.4.0 pair declared ahead of the broad comma-family rule); claims, watched shapes, contest roster and the P7 control re-recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A title/suffix dual (MD, Ms, Sr, the ranks) opens nothing (Derek): the
count before the comma cannot tell a two-word surname from a given
name and a family name, so 'García Márquez, Ms Gabriela', 'Dr. Smith,
Ms Jane' and 'García Márquez, Ms G. J.' lost their given names. The
dual branch, its full_name thunk and the paired-initials carve-out go;
the positional count is inline again with its one-piece early exit.
From the code review: run_start's merged-piece branch could never fire
(peel_walk drops the piece), so it is removed and the docstring no
longer implies the no-comma 'John Smith Ph. D. Jones' is fixed; C2's
flag test reads a period-joined title through period_joined_vocab
('John Smith, Jr., Lt.Gov.').
From the docs review: C1's strict sentence, run-start gloss and head
sentence, C2's ground (no name word past the second comma, not H5),
the #544 release bullet's "No field moves", AGENTS.md's tail and
bare-title passages, shapes.py's notation, and the decisions entry's
corpus label and grid, re-measured with the corpus read whole (four
corpus names move; 588 of 98,630 texts).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 45 45
Lines 4227 4252 +25
=======================================
+ Hits 4184 4209 +25
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ge.rst
- starts_a_credential_run accepts the merged 'suffix' piece only as the
bare Ph./D. pair: a connective join keeps the tag on the wider piece,
so 'John Smith, Ph. D. and Mary Jones' opened the part (taking 'Mary'
in silence) where 'PhD and Mary' does not.
- All five ledgers said 1.4.0 read tail titles as titles; it read them
as suffixes. The earlier correction never landed: its script asserted
late and wrote nothing.
- Comments: C2's ground in assign (no name word past the second comma,
not H5), classify (not group) tagging 'Lt.Gov.', the one-piece exit
in assign's count stated as the decision it is, and dual-draft
leftovers in test_pieces, a case note and segment_suffix_reading.
- Rows pinning what no test did: the one-piece exit ('Vega y Lopez, PhD
Jones'), the first-suffix-word boundary ('Smith, MA PhD Jones'), the
accepted 'Smith, Jr. John', and the connective spelling.
- usage.rst (Derek): form 3's part after the comma is "Suffix or Title"
too, as it already read ('Eric H. Holder, Attorney General'), with a
sentence on period-marked trailing titles; shapes.py follows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#603, C1: a part after the comma whose first suffix word, with only titles in front of it, starts S2's run is the postnominal part, however it goes on.
suffix-or-name, as Should a name word after a credential join the suffix?John Smith PhD Jonesreads middleSmith PhD#602's run does.John Smith, PhD Jones→ given John, family Smith, suffixPhD Jones.Doe, PhD Jones→ family Doe, suffixPhD Jones.MD,Ms,Sr, ranks) opens nothing (Derek's call, after review).Smith, Ms JaneandGarcía Márquez, Ms Gabrielakeep their title and given name, andJohn Smith, MD Jonesreads as in 2.3.Steven Hardman, RN - CRNA→ given Steven, family Hardman, suffixRN - CRNA.segment_suffix_readingrather than adding a structure.Spelling gap fixed: the merged
Ph. D.now starts #602's run and this one, asPhDdoes (Smith, John Ph. D. Joneskept middleJones). The no-commaJohn Smith Ph. D. Jonesis still open; the peel's walk never holds the merged piece. AGENTS.md's spelling sweep records it.#603, C2: a title word in a part past the second comma that is not also a suffix word is a title.
Eric H. Holder, Jr., Attorney General→ titleAttorney General, and a part of title and suffix words (or a period-joined title likeLt.Gov.) is no longer flagged. A title joined by a connective (Secretary of State) keeps the flag, because the flag test asks word by word rather than modelling group's chain. 1.4.0 through 2.3.0 all read these words as suffixes.usage.rst (Derek): form 3's part after the comma is
Suffix or Titletoo, as it already read (Eric H. Holder, Attorney General), with a sentence on period-marked trailing titles.#611: C1, S2 and P6 each show the decisive sign: a guard models what another stage will do. Rethinks are filed as #613 (C1, with P6 folded in) and #614 (S2), C1 first, neither for 2.4. The outcome is recorded in decisions.md under C1.
Measured against master at 97d36e0
Steven Hardman, RN - CRNA,John, Smith, Dr.,Andrew Perkins, Jr., Col. (Ret)and1 & 2, 3 4 5, Mr..Smith, Jr.163 → 156 andSmith, MD PhD260 → 253; the opened part pays for what it reads.Test Plan
uv run pytest: 11465 passeduv run mypy,uv run ruff checkJohn Smith, PhD Jonesreads familyJohn Smith#603 rules are classified at every baseline; the 1.4.0 pair is declaredprecedes_narrowerover the broad comma-family rule. Claims, watched shapes, the contest roster and the P7 control are re-recorded.sphinx-build -b doctestand-b htmlclean; README doctest/pr-review-toolkit:review-pr(code, tests with mutation checks, comments); findings fixed in ba6946eCloses #603
Closes #611
🤖 Generated with Claude Code