Correct AGENTS.md's particles.py bullet to rules.md#P1's one-site fold - #605
Merged
Merged
Conversation
The bullet still described the pre-#467 rule, with two fold sites (the opening piece and the given position), and gave "Mesnil de" under FAMILY_FIRST as folding into the family. rules.md#P1 and post_rules have one site, the opening piece, and that input reads given "de". Rewritten against the code and re-measured 2026-10-04 under all three orders. Also corrected: a bare "de" is family under the family-first orders, not given; "Juan de la Vega" under FAMILY_FIRST records no ambiguity; the fold's reach depends on the order (rest of the name by default, one unit under family-first, rest of the part after a family comma). The retired "rule 1b" label now points at P1. Dropped the uncited history about #359 and the pre-#367 "Sir de Mesnil" reading rather than keep claims nobody re-checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 45 45
Lines 4238 4238
=======================================
Hits 4195 4195
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md's
particles.pybullet (Architecture → Configuration layer) still described the pre-#467 fold, with two sites: the opening piece and the given position. Its example,"Mesnil de"underFAMILY_FIRSTfolding into the family, is false. rules.md#P1 states"Mesnil de" family-first → given="de", and the code in_post_rules.pyagrees: one site, the piece that opens the name.Docs only. No parser behavior changes, so there's no rules.md amendment.
What the rewrite says. Every example was measured on this tree on 2026-10-04 under all three
name_orders:Sir de Mesnilgives familyde Mesnilunder every order.de Mesnil Jean→ familyde Mesnil Jean).de Mesnil Jean→ familyde Mesnil, givenJean).Smith, de Mesnil Jean→ familySmith de Mesnil Jean).groupdoesn't chain it forward. The fold walks the particles after it, sode la Vegagives familyde la Vegaunder all three orders.Mesnil deunder either family-first order gives givende.Juan de la Vegaunder family-first gives familyJuan, givende la Vega, with no ambiguity recorded.van GoghrecordsPARTICLE_OR_GIVENunder all three orders.de MesnilandVincent van Goghrecord none.Other claims in the old bullet that were wrong:
de"keeps givende". That's only true under the default order. Under both family-first orders it's familyde, placed by position.Juan de la VegaunderFAMILY_FIRST: "1b declines and reports it". There's no given-position check left to decline, and nothing is reported.Ménil Christophe deunder FAMILY_FIRST drops the tussenvoegsel, andde Mesnil JuanreadsJuanas part of the surname #467, leading-only is the rule.Dropped rather than re-verified: the claim that #359 records the
Juan de la Vegacase as intended, and the pre-#367 history ofSir de Mesnil. Both are history, and the current behavior is stated instead.Tests: doc tests (
test_doc_*,test_rules_doc*) pass, 771.🤖 Generated with Claude Code