Repository navigation
Publish subagent summaries to parent sessions - #99
Merged
Merged
Conversation
Publish completed child summaries through the product-owned parent-session message publisher so the next parent prompt can see subagent results. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Bind session runtime contexts to the SessionManager publisher so subagent completions enter the existing runtime message bus without new HTTP or agentkit surface. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds infrastructure for publishing subagent completion and error summaries to a parent session. The ChangesSubagent Summary Publishing Flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 22 minutes and 54 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
coding-agent/tests/coding_agent/tools/test_subagent.py (1)
198-217: 💤 Low value
ImmediateAdapterandStubCoordinatorduplicate existing module-level helpers.The inline
ImmediateAdapter(lines 207-215) is identical to what_make_immediate_adapter()(line 385) returns, and the inlineStubCoordinator(lines 198-200) duplicates_StubCoordinator(line 399). Using the shared helpers keeps the new test consistent with the rest of the file and reduces future drift.♻️ Proposed fix
- class StubCoordinator: - def allocate_child_id(self, parent_agent_id: str) -> str: - return f"{parent_agent_id}.child-1" - child_ctx = PipelineContext(tape=Tape(), session_id="parent-session") def child_pipeline_builder(**_kwargs: Any): return cast(Pipeline, object()), child_ctx - class ImmediateAdapter: - def __init__(self, **_kwargs: Any) -> None: - pass - - async def run_turn(self, _goal: str) -> TurnOutcome: - return TurnOutcome( - stop_reason=StopReason.NO_TOOL_CALLS, - final_message="Child finished", - ) - - monkeypatch.setattr("coding_agent.tools.subagent.PipelineAdapter", ImmediateAdapter) + monkeypatch.setattr( + "coding_agent.tools.subagent.PipelineAdapter", _make_immediate_adapter() + ) tool_fn = build_subagent_tool(child_pipeline_builder) parent_ctx = PipelineContext( tape=Tape(), session_id="parent-session", config={ "agent_id": "parent-agent", "subagent_timeout": 30.0, - "child_worker_coordinator": StubCoordinator(), + "child_worker_coordinator": _StubCoordinator(), "subagent_message_publisher": publish_subagent_message, }, )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@coding-agent/tests/coding_agent/tools/test_subagent.py` around lines 198 - 217, The test defines duplicate helpers StubCoordinator and ImmediateAdapter; remove the inline StubCoordinator and ImmediateAdapter and reuse the module-level helpers _StubCoordinator and _make_immediate_adapter instead: instantiate _StubCoordinator for the coordinator usage (replace StubCoordinator) and call _make_immediate_adapter() (or use its returned class) for the PipelineAdapter monkeypatch (replace ImmediateAdapter and keep monkeypatch.setattr("coding_agent.tools.subagent.PipelineAdapter", _make_immediate_adapter()) or equivalent). Ensure you keep the same behavior and returned TurnOutcome by using those helpers so the test remains consistent with the rest of the file.coding-agent/src/coding_agent/ui/session_manager.py (1)
1376-1394: 💤 Low valueRedundant
_bind_subagent_message_publishercall inside the new-agent block.Line 1376 (inside the
if pipeline is None…block) is always superseded by line 1394 (unconditional). Both setctx.config["subagent_message_publisher"]to the same value, so the first call is unreachable dead work.♻️ Proposed fix
session.tape_id = ctx.tape.tape_id await self._persist_session_async(session) ctx.runtime_message_bus = session.runtime_message_bus ctx.config["wire_consumer"] = None ctx.config["agent_id"] = "" - self._bind_subagent_message_publisher(ctx) llm_plugin = pipeline._registry.get("llm_provider")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@coding-agent/src/coding_agent/ui/session_manager.py` around lines 1376 - 1394, Remove the redundant call to _bind_subagent_message_publisher inside the new-agent/pipeline initialization branch so it only runs once (the later unconditional call that sets ctx.config["subagent_message_publisher"]); specifically, delete the earlier invocation that occurs immediately after creating the PipelineAdapter and before assigning session.runtime_pipeline/ctx/adapter, leaving the single call after ctx.config["wire_consumer"] is set; ensure no other side-effects are lost by verifying _bind_subagent_message_publisher is still invoked exactly once and that adapter/set_consumer and llm_plugin assignment remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@coding-agent/src/coding_agent/tools/subagent.py`:
- Around line 144-151: The publisher call in _publish_subagent_summary can raise
and abort subagent_dispatch, so wrap the publisher(...) invocation (and the
subsequent await of publish_result when isawaitable(publish_result) is true) in
a try/except that catches Exception, logs the error (including exception
details) and continues instead of re-raising; keep the early return when
publisher is None unchanged, and ensure any awaiting of publish_result happens
inside the same try block so failures there are also non-fatal and
subagent_dispatch can still return summary.
---
Nitpick comments:
In `@coding-agent/src/coding_agent/ui/session_manager.py`:
- Around line 1376-1394: Remove the redundant call to
_bind_subagent_message_publisher inside the new-agent/pipeline initialization
branch so it only runs once (the later unconditional call that sets
ctx.config["subagent_message_publisher"]); specifically, delete the earlier
invocation that occurs immediately after creating the PipelineAdapter and before
assigning session.runtime_pipeline/ctx/adapter, leaving the single call after
ctx.config["wire_consumer"] is set; ensure no other side-effects are lost by
verifying _bind_subagent_message_publisher is still invoked exactly once and
that adapter/set_consumer and llm_plugin assignment remain unchanged.
In `@coding-agent/tests/coding_agent/tools/test_subagent.py`:
- Around line 198-217: The test defines duplicate helpers StubCoordinator and
ImmediateAdapter; remove the inline StubCoordinator and ImmediateAdapter and
reuse the module-level helpers _StubCoordinator and _make_immediate_adapter
instead: instantiate _StubCoordinator for the coordinator usage (replace
StubCoordinator) and call _make_immediate_adapter() (or use its returned class)
for the PipelineAdapter monkeypatch (replace ImmediateAdapter and keep
monkeypatch.setattr("coding_agent.tools.subagent.PipelineAdapter",
_make_immediate_adapter()) or equivalent). Ensure you keep the same behavior and
returned TurnOutcome by using those helpers so the test remains consistent with
the rest of the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cdd3fb70-0368-4843-8b60-17b9931839f5
📒 Files selected for processing (4)
coding-agent/src/coding_agent/tools/subagent.pycoding-agent/src/coding_agent/ui/session_manager.pycoding-agent/tests/coding_agent/tools/test_subagent.pycoding-agent/tests/ui/test_session_manager_public_api.py
Keep completed subagent runs from surfacing as tool errors when the optional parent-session publisher fails, and cover the non-fatal path with a regression test. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Drop the redundant run-agent bootstrap binding now that the later unconditional session runtime binding covers the same context path. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Publish timeout results through the same parent-session summary path as completion and error outcomes so the runtime bus always receives a subagent status message. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish_subagent_messagewithout adding new agentkit, HTTP, or UI surface.Verification
uv run pytest tests/coding_agent/tools/test_subagent.py tests/ui/test_session_manager_public_api.py -quv run basedpyright src/coding_agent/tools/subagent.py src/coding_agent/ui/session_manager.py tests/coding_agent/tools/test_subagent.py tests/ui/test_session_manager_public_api.py --level errorpython3 -m py_compile src/coding_agent/tools/subagent.py src/coding_agent/ui/session_manager.py tests/coding_agent/tools/test_subagent.py tests/ui/test_session_manager_public_api.pyGIT_MASTER=1 git diff --check HEADsubagent_messagefrom the parent bus.Summary by CodeRabbit