Repository navigation
fix(shell): skip git URLs in path-escape check - #741
Merged
Merged
Conversation
bash_run sandbox_mode=none treated https Git URLs as absolute paths and blocked clone.
delete-cloud
force-pushed
the
fix/bash-run-git-url-path-escape
branch
from
September 8, 2026 14:02
aa5a1e9 to
d201e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash_runwithsandbox_mode=nonetreatedhttps://github.com/org/repo.gitas filesystem path/github.com/org/repo.gitand rejectedgit clone.Skip argv tokens that are remote URLs (
https://,http://,git+https://,git+http://,git+ssh://,ssh://,git://, andgit@host:path). Other argv tokens still go through the path-escape check, sogit clone <url> /outsideremains blocked.Tests
40 passed.
Local K3 + Grok re-review of
aa5a1e90: both APPROVE, no remaining P0–P2.Scope
coding-agent/src/coding_agent/tools/shell.pycoding-agent/tests/tools/test_shell.py