Repository navigation
fix(chat): persist user_prompt without command_id - #740
Closed
delete-cloud wants to merge 1 commit into
Closed
delete-cloud wants to merge 1 commit into
delete-cloud wants to merge 1 commit into
Conversation
JSON POST /sessions/{id}/prompt now admits through the connected-chat
UoW even when command_id is omitted, so reload and GET /sessions see
the user text. Client-supplied command_id still selects chat_event SSE.
serve --help documents WEBUI_DIST_DIR for Night Console app-next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /sessions/{id}/promptnow admits through the connected-chat UoW even whencommand_idis omitted, so snapshot/reload andGET /sessionssee the user text.command_idstill selects canonicalchat_eventSSE. Omittedcommand_idkeeps the legacy wire/display stream.serve --helpdocumentsWEBUI_DIST_DIRfor a Night Console (webui/app-next) export. Defaultservestays API-only.Implements the first after-acceptance gap from ADR-0079 (PR 739, still Proposed). Does not delete
run --goal/run --tui, does not start Phase H, does not flip productionnew_sessions_enabled.Test plan
uv run pytest tests/ui/test_connected_chat_http.py::test_prompt_without_command_id_writes_user_prompt tests/ui/test_connected_chat_http.py::test_rejected_prompt_without_command_id_writes_no_user_prompt tests/coding_agent/test_connected_chat_admission.py tests/ui/test_connected_chat_http.py tests/cli/test_entrypoint_contract.py::test_serve_help_documents_night_console_webui_dist -qtest