Skip to content

fix(webui): keep codex accounts reachable without an active session - #691

Merged
delete-cloud merged 1 commit into
mainfrom
fix/webui-settings-codex-no-session
Aug 2, 2026
Merged

delete-cloud merged 1 commit into
mainfrom
fix/webui-settings-codex-no-session

Conversation

@delete-cloud

@delete-cloud delete-cloud commented Aug 2, 2026 •

Copy link
Copy Markdown
Owner

无会话时 Settings 面板显示 "No active session" 占位符,把后端全局的 codex 账号卡片也挡住了,导致无法登录 codex。

SettingsPanel 的 sessionId 改为可空:会话级运行时设置只在选中会话时显示,codex 账号卡片始终渲染。129 vitest 全绿。

Summary by CodeRabbit

  • New Features

    • Settings can now be opened and viewed even when no session is active.
    • Codex account information remains accessible without selecting a session.
    • Runtime settings controls are shown when a session is selected, with guidance provided otherwise.
  • Bug Fixes

    • Prevented settings updates from failing when no active session exists.

The Settings rail showed a 'No active session' placeholder when no
session was selected, which also hid the codex accounts card — a
backend-global feature — making codex login unreachable. SettingsPanel
now takes a nullable sessionId: runtime controls show only with a
session, the codex card always renders.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The settings rail now renders SettingsPanel without an active session. Runtime settings require a selected session, while the Codex accounts card remains available. Tests cover the no-session prompt and mocked OAuth endpoints.

Changes

Session-independent settings panel

Layer / File(s) Summary
SettingsPanel session states
coding-agent/webui/app/src/components/SettingsPanel.tsx
SettingsPanel accepts a nullable session ID. Runtime settings render only for a selected session. The no-session message and backend-wide Codex accounts card remain available.
App integration and validation
coding-agent/webui/app/src/App.tsx, coding-agent/webui/app/src/App.test.tsx
App renders the settings panel without a session and makes session updates a no-op in that state. The test verifies the session-selection prompt and mocked OAuth account flow.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes keeping Codex accounts accessible without an active session.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/webui-settings-codex-no-session

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@coding-agent/webui/app/src/App.test.tsx`:
- Around line 1910-1930: Update the test case “shows the codex accounts card
when there is no active session” to assert the Codex accounts card’s stable
accessible heading or account action after the OAuth mocks resolve, while
retaining the existing no-session message assertion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f9abe89f-c5b4-47c4-b89a-072fe9b51372

📥 Commits

Reviewing files that changed from the base of the PR and between 7bd7b3b and 82481cb.

📒 Files selected for processing (3)
  • coding-agent/webui/app/src/App.test.tsx
  • coding-agent/webui/app/src/App.tsx
  • coding-agent/webui/app/src/components/SettingsPanel.tsx

Comment thread coding-agent/webui/app/src/App.test.tsx
@delete-cloud
delete-cloud merged commit ff5b5ea into main Aug 2, 2026
2 checks passed
@delete-cloud
delete-cloud deleted the fix/webui-settings-codex-no-session branch August 2, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant