Repository navigation
fix(webui): keep codex accounts reachable without an active session - #691
Conversation
The Settings rail showed a 'No active session' placeholder when no session was selected, which also hid the codex accounts card — a backend-global feature — making codex login unreachable. SettingsPanel now takes a nullable sessionId: runtime controls show only with a session, the codex card always renders.
📝 WalkthroughWalkthroughThe settings rail now renders ChangesSession-independent settings panel
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@coding-agent/webui/app/src/App.test.tsx`:
- Around line 1910-1930: Update the test case “shows the codex accounts card
when there is no active session” to assert the Codex accounts card’s stable
accessible heading or account action after the OAuth mocks resolve, while
retaining the existing no-session message assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f9abe89f-c5b4-47c4-b89a-072fe9b51372
📒 Files selected for processing (3)
coding-agent/webui/app/src/App.test.tsxcoding-agent/webui/app/src/App.tsxcoding-agent/webui/app/src/components/SettingsPanel.tsx
无会话时 Settings 面板显示 "No active session" 占位符,把后端全局的 codex 账号卡片也挡住了,导致无法登录 codex。
SettingsPanel 的 sessionId 改为可空:会话级运行时设置只在选中会话时显示,codex 账号卡片始终渲染。129 vitest 全绿。
Summary by CodeRabbit
New Features
Bug Fixes