Skip to content

ci: combine woodpecker lint and smoke steps - #659

Merged
delete-cloud merged 1 commit into
mainfrom
ci/woodpecker-install-once
Jun 30, 2026
Merged

delete-cloud merged 1 commit into
mainfrom
ci/woodpecker-install-once

Conversation

@delete-cloud

@delete-cloud delete-cloud commented Jun 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • combine Woodpecker lint and smoke-tests into one Python step
  • keep the same ruff and pytest commands while installing dependencies once
  • leave image build and deploy-tools steps unchanged

Verification

  • python3 yaml.safe_load .woodpecker/ci.yml with step/count assertions
  • git diff --check -- .woodpecker/ci.yml
  • local subagent P1/P2 review: clean

Summary by CodeRabbit

  • Chores
    • Streamlined the continuous integration pipeline by combining code checks and smoke tests into a single step.
    • Updated the build workflow to install required development tools once, then run both static checks and targeted test coverage in sequence.
    • Removed redundant pipeline steps to simplify maintenance and reduce duplication.

Run the focused Woodpecker lint and smoke checks in one Python step so dependencies are installed once per workflow instead of once per step.

Verification:

- python3 yaml.safe_load .woodpecker/ci.yml with step/count assertions

- git diff --check -- .woodpecker/ci.yml

- local subagent P1/P2 review: clean
@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 71193fa4-42a4-46f0-9df0-51961b7337df

📥 Commits

Reviewing files that changed from the base of the PR and between 8fce060 and d98daeb.

📒 Files selected for processing (1)
  • .woodpecker/ci.yml

📝 Walkthrough

Walkthrough

The Woodpecker CI pipeline consolidates the separate lint and smoke-tests steps into a single lint-and-smoke-tests step that installs ruff alongside dev dependencies, runs ruff check, and executes the pytest smoke/compat suite.

Changes

CI Pipeline Consolidation

Layer / File(s) Summary
Unified lint-and-smoke-tests step
.woodpecker/ci.yml
Renames the lint step to lint-and-smoke-tests and updates its commands to install ruff, run ruff check on the listed modules/tests, and execute the targeted pytest suite, replacing the prior separate steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐇 Two steps were many, one step is fine,
Lint and smoke-tests now share a single line.
Ruff checks the code, pytest runs the rest,
A tidier pipeline passes every test!
One job to rule them, neat and aligned~ ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/woodpecker-install-once

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@delete-cloud
delete-cloud marked this pull request as ready for review June 30, 2026 08:04
@delete-cloud
delete-cloud merged commit 2244e01 into main Jun 30, 2026
1 of 2 checks passed
@delete-cloud
delete-cloud deleted the ci/woodpecker-install-once branch June 30, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant