Skip to content

fix(helm): use venv python for KB index job #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delete-cloud merged 1 commit into from
Jun 15, 2026
Merged

fix(helm): use venv python for KB index job #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coding-agent/helm/templates/cronjob-kb-index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:

{{- range .Values.kb.index.repos }}
git clone --depth 1 --branch {{ $.Values.kb.index.gitRef | quote }} {{ required "kb.index.repos[].url is required" .url | quote }} "$workdir/{{ required "kb.index.repos[].name is required" .name }}"
kb index "$workdir/{{ required "kb.index.repos[].name is required" .name }}" --corpus {{ required "kb.index.repos[].corpus is required" .corpus | quote }}
/app/.venv/bin/python -m coding_agent kb index "$workdir/{{ required "kb.index.repos[].name is required" .name }}" --corpus {{ required "kb.index.repos[].corpus is required" .corpus | quote }}
{{- end }}
{{- if or .Values.agent.secretRef .Values.kb.index.gitSecretName }}
envFrom:
Expand Down
4 changes: 3 additions & 1 deletion coding-agent/tests/deploy/test_helm_chart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import os
import re
import shutil
import subprocess
import tomllib
Expand Down Expand Up @@ -677,7 +678,8 @@ def test_helm_kb_index_cronjob_renders_pvc_env_and_netpol_labels() -> None:
script = "\n".join(container["command"])
assert "git clone --depth 1 --branch \"main\"" in script
assert "<forgejo-host>/<owner>/sre.git" in script
assert "kb index" in script
assert "/app/.venv/bin/python -m coding_agent kb index" in script
assert re.search(r"(^|\n)\s*kb\s+index(\s|$)", script) is None
assert "--corpus \"sre\"" in script


Expand Down
Loading