Skip to content

docs: add ADR 0026 git review flow - #174

Merged
delete-cloud merged 1 commit into
mainfrom
docs/adr-0026-git-review-flow-v2
May 15, 2026
Merged

delete-cloud merged 1 commit into
mainfrom
docs/adr-0026-git-review-flow-v2

Conversation

@delete-cloud

@delete-cloud delete-cloud commented May 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add ADR-0026 for Git Review Flow v2 as the next remote result publication hardening step
  • keep Git review flow implementation in coding_agent and only mark future agentkit result/artifact boundaries
  • define consistency, source clone allowlist, publish preflight, partial publication, and acceptance criteria

Validation

  • grep -n '[[:blank:]]$' coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md
  • rg -n 'TODO|TBD|placeholder' coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md
  • git diff --check

Summary by CodeRabbit

  • Documentation
    • Added architecture documentation for Git Review Flow v2, defining the remote result publication model with enhanced safety mechanisms and validation processes.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea75044f-2af5-458f-8888-180b3f58f5fb

📥 Commits

Reviewing files that changed from the base of the PR and between 159b2eb and 6324cd4.

📒 Files selected for processing (1)
  • coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md

📝 Walkthrough

Walkthrough

This PR introduces ADR-0026 documenting the "Git Review Flow v2" hardening model for remote result publication. The document specifies strict content consistency between review artifacts and published commits, retry-safe preflight validation before workspace mutations, fail-closed Git source safety via URL allowlisting, durable response metadata, and a multi-PR implementation plan with explicit non-goals and acceptance criteria.

Changes

ADR-0026: Git Review Flow v2 Remote Result Publication Hardening

Layer / File(s) Summary
ADR framing and background
coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md
ADR metadata, problem context from prior ADRs (0024, 0025), and definition of remaining production-quality gaps for retry/inspection behavior and fail-closed Git operations.
Core decision and publication constraints
coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md
Central "Git Review Flow v2" decision defining remote artifact success path, content-consistency rules between diff/patch and publication commits, preflight validation ordering before workspace mutations, Git source clone safety via URL allowlisting, and durable response metadata schema with status, refs, redacted URLs, and retry guidance.
Architecture, non-goals, implementation plan, and acceptance criteria
coding-agent/docs/adr/0026-remote-result-publication-v2-git-review-flow.md
Layering constraints keeping core within coding_agent, explicit non-goals (no live sync, no automatic merge, no broad provider abstraction), consequences for product boundary, multi-PR implementation roadmap with tests, temporary-index diff/patch, clone validation, and metadata persistence, rejected alternatives, and specific test acceptance criteria with example pytest/ruff/basedpyright commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~8 minutes

Possibly related PRs

  • delete-cloud/Coding-Agent-Loop#161: Both ADRs (0026 and 0025) are closely connected around hardened remote result publication semantics with durable remote session/workspace retention and related constraints for remote Git operations.
  • delete-cloud/Coding-Agent-Loop#142: ADR-0026 builds directly on the remote result publication concepts from ADR-0024 (git-backed workspace source, publication modes, and review artifact consistency).

Poem

🐰 A review flow takes shape with careful git,
Preflight checks ensure all artifacts fit,
No silent failures, no unsafe clone,
Metadata durable—the truth is known,
A hardened path where safety and review are one.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-0026-git-review-flow-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@delete-cloud
delete-cloud merged commit 666e3e6 into main May 15, 2026
1 check was pending
@delete-cloud
delete-cloud deleted the docs/adr-0026-git-review-flow-v2 branch May 15, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant