Repository navigation
feat: make remote run result-first - #148
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthrough
ChangesRemote run download and cleanup control
Sequence Diagram(s)sequenceDiagram
participant CLI as "remote run / remote repl"
participant Handler as "_remote_run_once"
participant RemoteAPI as "Remote session API"
participant LocalFS as "Local workspace (manifest/archive)"
CLI->>Handler: start session (repo?, download_results, cleanup_on_success)
Handler->>RemoteAPI: create session / run actions
RemoteAPI-->>Handler: session id, result archive available
Handler->>RemoteAPI: optionally GET /sessions/<id>/manifest (if download_results)
RemoteAPI-->>Handler: manifest
Handler->>RemoteAPI: optionally GET /sessions/<id>/archive (if download_results)
RemoteAPI-->>Handler: archive
Handler->>LocalFS: extract/apply archive (if download_results)
Handler->>RemoteAPI: DELETE /sessions/<id> (if cleanup_on_success)
Handler-->>CLI: print success + either cleanup message or next-step commands
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@coding-agent/src/coding_agent/__main__.py`:
- Around line 527-530: The help text for the CLI flag "--repo" under the "remote
repl" command is incorrect (it claims results stay remote unless a non-existent
"--download" is passed) — update the help string in the argument definition (the
add_argument call that defines "--repo" in coding_agent.__main__.__main__ / CLI
setup) to accurately reflect actual behavior (that specifying --repo triggers
auto-download of results), or alternatively change the implementation in the
remote repl handler to match the help; reference the "--repo" add_argument and
the "remote repl" command handler where repo-upload/auto-download occurs and
make the help and behavior consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c07c5db8-6b85-4d6d-ba41-b0d5522236b0
📒 Files selected for processing (2)
coding-agent/src/coding_agent/__main__.pycoding-agent/tests/cli/test_remote_client.py
Summary
remote runleave the session open by default for result inspectionremote run --download --yesremote replcompatibility behavior unchangedValidation
uv run pytest tests/cli/test_remote_client.py -k "remote_run or remote_repl_with_repo or remote_diff or remote_patch or download" -quv run basedpyright --level error src/coding_agent/__main__.py tests/cli/test_remote_client.pyuv run ruff format --check src/coding_agent/__main__.py tests/cli/test_remote_client.pygit diff --checkSummary by CodeRabbit
New Features
--downloadflag toremote runfor explicit workspace download and cleanup.Bug Fixes / Behavior
--yesconfirmation now applies only when downloading.Documentation
--repohelp to state results stay remote unless--downloadis used.Tests