Repository navigation
docs: mark ADR-0021 implemented - #129
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughADR-0021 documentation is updated with a concrete specification for Docker workspace provider archive digest computation and acceptance criteria checklist items marked as complete, confirming test coverage for session operations, admin-scope enforcement, workspace cleanup, archive manifest reporting, and CLI download workflows. ChangesADR-0021 Remote Session and Workspace Operations API
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@coding-agent/docs/adr/0021-remote-session-and-workspace-operations-api.md`:
- Around line 357-371: Update the ADR header by changing the status line
"Status: Proposed" to "Status: Accepted" (or "Implemented") to reflect that all
acceptance criteria (the checked list including tests like
test_list_sessions_returns_visible_session_summaries,
test_cancel_session_turn_returns_cancelling_for_active_turn,
test_workspace_archive_manifest_reports_counts_bytes_and_changes, etc.) are
complete; ensure the single-line "Status:" field in
0021-remote-session-and-workspace-operations-api.md is updated and save the ADR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a55bd944-3c2f-4079-b092-91ab27958b60
📒 Files selected for processing (1)
coding-agent/docs/adr/0021-remote-session-and-workspace-operations-api.md
Comment on lines
+357
to
371
| - [x] `test_list_sessions_returns_visible_session_summaries` | ||
| - [x] `test_list_sessions_requires_admin_scope_for_all_sessions` | ||
| - [x] `test_get_session_response_includes_status_and_workspace_summary` | ||
| - [x] `test_cancel_session_turn_returns_cancelling_for_active_turn` | ||
| - [x] `test_cancel_session_turn_exposes_cancelled_final_state` | ||
| - [x] `test_cancel_session_turn_rejects_non_owner` | ||
| - [x] `test_workspaces_list_requires_admin_scope` | ||
| - [x] `test_workspace_cleanup_requires_admin_scope` | ||
| - [x] `test_workspace_cleanup_skips_active_cloud_sessions` | ||
| - [x] `test_workspace_archive_manifest_reports_counts_bytes_and_changes` | ||
| - [x] `test_session_workspace_archive_endpoint_keeps_compatibility_alias` | ||
| - [x] `test_remote_run_uses_create_prompt_manifest_download_flow` | ||
| - [x] `test_remote_download_prompts_before_overwriting_local_workspace` | ||
| - [x] `uv run pytest tests/ui/test_http_server.py tests/ui/test_http_server_workspace_transfer.py tests/cli/test_remote_client.py tests/coding_agent/environment/ -k "session or workspace or remote or cancel or manifest or admin" -v` | ||
|
|
Contributor
There was a problem hiding this comment.
Align ADR state with completed acceptance criteria.
Lines 357–371 show all criteria completed, but the document still says Status: Proposed (Line 3). Please update the ADR status to reflect implemented/accepted state to avoid governance drift.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@coding-agent/docs/adr/0021-remote-session-and-workspace-operations-api.md`
around lines 357 - 371, Update the ADR header by changing the status line
"Status: Proposed" to "Status: Accepted" (or "Implemented") to reflect that all
acceptance criteria (the checked list including tests like
test_list_sessions_returns_visible_session_summaries,
test_cancel_session_turn_returns_cancelling_for_active_turn,
test_workspace_archive_manifest_reports_counts_bytes_and_changes, etc.) are
complete; ensure the single-line "Status:" field in
0021-remote-session-and-workspace-operations-api.md is updated and save the ADR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit
Documentation
Tests