This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Repository navigation
Allow quoted js source references to support minimatch globs - #28
Merged
Merged
Conversation
added 2 commits
January 25, 2015 20:07
… output from invalid flags.
|
I'm running in to the same problem due to command line length in Windows. This PR would solve it as it allows passing glob patterns to the compiler, which drastically reduces the length of the executed command. @dcodeIO can this be merged? |
|
Run in the same issue under Windows with the "Error: spawn ENAMETOOLONG". |
dcodeIO
added a commit
that referenced
this pull request
Jul 25, 2015
Allow quoted js source references to support minimatch globs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure-compiler now supports minimatch-style glob inputs. This allows for very large number of files to be passed to the compiler. On windows, command length arguments prohibit passing large source repositories (like all of closure-library) to the compiler directly.
To support this functionality, I allowed input sources to be quoted, and if so did not verify that they match an existing file.
I also added an error event so that invalid compiler option error messages would be correctly reported.