Repository navigation
Conversation
An instance whose project cluster never becomes available used to retry quietly every 15 seconds forever. After 10 minutes the wait is now logged at the normal level with the instance name, counted in the compute_instance_projector_stalled_projections gauge, and retried once a minute. The wait is measured from the first retry this process saw, so a restart does not report every instance at once. Also names the instance DNS status reasons as constants and adds a reconcile-level test that a location without Private DNS is reported in status and retried on the normal resync schedule.
|
|
Address review findings: log the stall at the normal level only when it crosses the bound, and end a wait only when a reconcile completes, so a transient error in between does not hide a real stall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Scot Schuchert-Wells
Summary
An instance whose project never becomes available used to retry silently every 15 seconds, forever. Now, once an instance has waited 10 minutes:
compute_instance_projector_stalled_projectionsgauge counts it, andThe wait is measured from the first retry the controller saw, so a restart, when short waits are expected, does not report every instance at once. The count clears when the instance stops waiting.
Also:
Addresses #521. Part of #566.
Related: datum-cloud/enhancements#921