Repository navigation
ci(e2e): wait for the Karmada control-plane rollout before registering cells - #610
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
…g cells Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
scotwells
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E environment step sometimes failed while it registered cell clusters with the Karmada API server. The harness tunes the Karmada control plane by restarting it, then reads and writes through an API server that is still coming back, and the final write is not retried. Provisioning now waits for the control plane to finish starting before it registers cells.
Why this fix
Five of the last 100
mainE2E runs failed in Provision Kind + Karmada environment, each with the Karmada API server at127.0.0.1:32443unreachable (connection reset by peer/EOF); the other ten failures were in Run Chainsaw e2e suites, a separate class. The tuning steps patch the Karmada pod templates (disable-leader-election,disable-etcd-fsyncdeletingetcd-0, the API-server probe patch), so a rollout is in flight. The gatekubectl wait --for=condition=Available deploy --allreturns from the old pod, so the harness configured the API and registered cells while the API server was restarting, and the un-retriedpatch-cluster-secret.shfailed on the first dropped connection. Waiting for the rollout matches the gate's stated intent, "converge before we build the kubeconfig and register cells".Fix walkthrough
Watch the fix explained (1:34). Recorded for commit
863ac9021a17836b9277c0b44fe31514f658e01b.Production impact
CI-only Taskfile change; no deployed resource behavior
The only changed file is
Taskfile.yaml, the local E2E harness definition. It runs in the GitHub Actions runner, not in production. The compute repository's only deployment edge is an OCI image built fromDockerfile(ghcr.io/datum-cloud/compute), which this change does not touch. I checked the repository node's edges: it defines that image and is owned by teams, with no runtime resource that readsTaskfile.yaml.Checked and not affected (1)
computeObservability
E2E Testsworkflow under Provision Kind + Karmada environment; on failure the harness uploadse2e-diagnosticsincludingkarmada-pods.txt.kubectl rollout statusoutput and the final lineKarmada control plane is Available and rolled out.Polylane assessed this pull request at
863ac90.Causal chain
1 file changed (+17/-2)
Taskfile.yaml: modified, +17/-2Repository lint:
make lint(declared in Makefile) did not finish within its time budget, so its verdict is not known; run it before merging.Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment.