[rodrigobarona]

Fixes #159.

What

serializeDiagnostics now redacts credentials and keeps the rest of the payload intact:

• Non-empty string values under credential-like keys become [Redacted]. Matching ignores case and punctuation: suffix apikey, accesstoken, refreshtoken, secret or password; exact token, idtoken, codeverifier, authorization, bearer or cookie. Empty strings are kept, so a missing key is still visible. Numeric fields such as anthropicModelMaxOutputTokens are untouched.
• sk-… API keys and Bearer … tokens embedded in any string are replaced.

This covers configuration.*ApiKey, activeApiKey and oauthCredentials.token.accessToken in the AgentFrame failure payload.

Tests

• diagnostics.test.ts: the deterministic-output test now expects redaction. New test covers provider keys, OAuth token/refresh/PKCE fields, mcpAccessToken and embedded Bearer/sk- strings.
• AgentFrame.test.tsx: the copied diagnostics no longer contain the API key or OAuth token.
• npm run typecheck, npm run lint, npm test (952 passed).

[roger-datocms]

(Claude here [Opus 5.5])

Triage

The fix is still needed. On master (6f57d960), dato-agent/src/lib/diagnostics.ts has no redaction. AgentFrame.tsx:3228-3236 copies props.config, activeApiKey and oauthCredentials into the payload verbatim.

Status

• Mergeable, state CLEAN, one commit (309223a8) on top of master 6f57d960. No CI checks run on this repo.
• Local run on the PR head: npm test 952/952 pass, npm run lint clean, npm run build succeeds.

Review findings

1. Gap: real Error instances skip string redaction. The Error branch (diagnostics.ts, current instanceof Error) copies message and stack raw and never calls normalize on them. AgentFrame.tsx:3276 passes thrownError, which is usually a real Error. I verified it: serializeDiagnostics({ error: new Error('Authorization: Bearer abc… sk-proj-…') }) keeps both secrets in message and stack. The new test only uses a plain-object error, so it misses this. Fix: run redactSensitiveSubstrings on message and stack, and add an Error case to the test.
2. Map keys: Map entries bypass key-based redaction. A Map with an authorization key keeps its value. This is low risk for the current payload. A one-line check in the Map branch closes it.
3. Duplicated patterns: the plugin already has the same regexes in conversations.ts:201-204, datoMcpClient.ts:113-114 and agentRuntime.ts:2447-2454. They use [redacted] (lowercase) and a 12-char sk- minimum. This PR uses [Redacted] and 16. Align the marker and threshold, or extract one shared helper.
4. Not covered: key=value secrets inside strings, for example ?access_token=… in a URL. conversations.ts already handles this with SECRET_KEY_VALUE_PATTERN. Reusing it here closes that gap.

Key matching (isSensitiveKey) looks right. It keeps numeric fields like anthropicModelMaxOutputTokens and empty strings, as intended.

Recommendation

Fix finding 1 before merge, because it is the leak that matters most in practice. Findings 2-4 are cheap and can go in the same commit. After that, merge, then close #159.

[roger-datocms]

(I'm working on this one, adding a few more secrets to redact before we merge)

[roger-datocms]

I pushed a few followup fixes to this:

• It checks secrets against the secrets values before logging (instead of via regex), since the plugin knows what they are
• Move diagnosticConfiguration() to an allowlist model to only log specified keys
• The credential-key-name list from Rodrigo's commit stays, for nested objects such as headers.authorization
• Things that "look like secrets" (but are not UUIDs or Dato IDs) will ask the user to confirm redaction before copying, interactively

I didn't want to absorb a full security sweeper like Gitleaks into this plugin, so hopefully this is good enough for now.

pr-161-walkthrough.mp4