Repository navigation
Refactor/deprecate functions - #519
Merged
Merged
Conversation
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Indicated of removal but:
- vectorDS not removed
- table1DDS not removed
- checkNegValueDS.R not removed
Member
|
When merged will address renaming:
and associated secondary changes to clients, tests, and documentation |
StuartWheater
self-requested a review
October 19, 2026 09:46
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Notes in wiki https://wiki.datashield.org/e/en/opmanag/release-notes_7-0-0 indicate the following also are to be removed:
- vectorDS
- table1DDS
- checkNegValueDS.R
StuartWheater
self-requested a review
October 22, 2026 11:37
StuartWheater
approved these changes
Oct 22, 2026
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Thoughts about removing removed: vectorDS, table1DDS and checkNegValueDS.R
- checkNegValueDS.R is still used by glmChecks.R, but not sure why checks aren't server-side to server-side and client-side to client-side
- vectorDS used in ds.recodeLevels as a wrapper around 'c' method
- table1DDS user in ds.table1DS and ds.summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.