Skip to content

Refactor/deprecate functions - #519

Merged
timcadman merged 1 commit into
v7.0-devfrom
refactor/deprecate-functions
Oct 23, 2026
Merged

timcadman merged 1 commit into
v7.0-devfrom
refactor/deprecate-functions

Conversation

@timcadman

Copy link
Copy Markdown
Contributor

No description provided.

@timcadman
timcadman changed the base branch from v6.3.6-dev to v7.0-dev October 15, 2026 14:51

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicated of removal but:

  • vectorDS not removed
  • table1DDS not removed
  • checkNegValueDS.R not removed

@StuartWheater

Copy link
Copy Markdown
Member

When merged will address renaming:

  • asFactorDS1.R to asFactor1DS.R
  • asFactorDS2.R to asFactor2DS.R
  • dataFrameSubsetDS1.R to dataFrameSubset1DS.R
  • dataFrameSubsetDS2.R to dataFrameSubset2DS.R
  • glmDS1.R to glm1DS.R
  • glmDS2.R to glm2DS.R
  • glmSLMADS1.R to glmSLMA1DS.R
  • glmSLMADS2.R to glmSLMA2DS.R
  • glmerSLMADS2.R to glmerSLMA2DS.R
  • histogramDS1.R to histogram1DS.R
  • histogramDS2.R to histogram2DS.R
  • kurtosisDS1.R to kurtosis1DS.R
  • kurtosisDS2.R to kurtosis2DS.R
  • lexisDS1.R to lexis1DS.R
  • lexisDS2.R to lexis2DS.R
  • lexisDS3.R to lexis3DS.R
  • matrixDetDS1.R to matrixDet1DS.R
  • matrixDetDS2.R to matrixDet2DS.R
  • skewnessDS1.R to skewness1DS.R
  • skewnessDS2.R to skewness2DS.R
  • tableDS2.R to table2DS.R

and associated secondary changes to clients, tests, and documentation

@StuartWheater
StuartWheater self-requested a review October 19, 2026 09:46

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes in wiki https://wiki.datashield.org/e/en/opmanag/release-notes_7-0-0 indicate the following also are to be removed:

  • vectorDS
  • table1DDS
  • checkNegValueDS.R

@StuartWheater
StuartWheater self-requested a review October 22, 2026 11:37

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts about removing removed: vectorDS, table1DDS and checkNegValueDS.R

  • checkNegValueDS.R is still used by glmChecks.R, but not sure why checks aren't server-side to server-side and client-side to client-side
  • vectorDS used in ds.recodeLevels as a wrapper around 'c' method
  • table1DDS user in ds.table1DS and ds.summary

@timcadman
timcadman merged commit 1de9eaa into v7.0-dev Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants