fix(db): avoid duplicate Doris and StarRocks connection parameters - #1397
Open
sunlishuo25 wants to merge 1 commit into
Open
sunlishuo25 wants to merge 1 commit into
sunlishuo25 wants to merge 1 commit into
Conversation
sunlishuo25
marked this pull request as ready for review
October 3, 2026 02:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doris/StarRocks table discovery fails when additional connection parameters are set, for example
extraJdbc="charset=utf8mb4":get_driver_connectionpasses both**conn_confand**args, althoughargsalready containsconn_confplus the SSL options. This removes the duplicate expansion from the direct-connection branch.The regression tests cover both databases, SSL on/off, empty and nonempty parameters, explicit overrides, and pooled connections. On main (
e02f717), 8 cases fail and 8 controls pass. With the fix, all 16 pass; the 13 existing connection-pool, SQL Server, and Hive tests also pass.Also checked with real PyMySQL 1.2.3 using
defer_connect=True: both connection objects are created withcharset=utf8mb4, without opening a socket. Tests use Python 3.11.9 and the existing AST-isolation pattern with the realDatasourceConfmodel. A live Doris/StarRocks server and full application startup were not tested.The new test file passes Ruff and format checks.
db.pyhas the same 14 existing Ruff findings before and after the change; no unrelated formatting was applied. Searches found no matching issue or open PR (#1390 is a separate Hive authentication problem).