Repository navigation
Conversation
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
| raise ValueError( | ||
| "enable_geospatial_support must be a bool; " f"got {type(value).__name__}" | ||
| ) | ||
| if not _kernel_session_accepts_kwarg("enable_geospatial_support"): |
There was a problem hiding this comment.
Could we raise the optional databricks-sql-kernel dependency minimum to the first published wheel that accepts enable_geospatial_support before this ships? pyproject.toml still allows ^1.1.0, while this keyword is checked on every kernel-backed open_session, even for queries with no geo columns. If a user upgrades the Python driver but retains an allowed older kernel wheel, would every kernel connection fail with NotSupportedError? Could we cover the minimum-supported-wheel installation in a compatibility test?
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
aakash-saravanan-db
left a comment
There was a problem hiding this comment.
Python-side implementation looks good. Please resolve the existing minimum-supported Kernel wheel/dependency-floor comment before merging. The additional durable E2E coverage suggestion is nonblocking.
Summary
enable_geospatial_supportconnection option{"srid": int, "wkb": bytes}values when enabled and WKT / EWKT strings when disabledDependency
Depends on databricks/databricks-sql-kernel#361
Validation