Skip to content

Allow installing with numpy>=2 #509

Closed

Description

@dhirschfeld

numpy = [
{ version = "^1.16.6", python = ">=3.8,<3.11" },
{ version = "^1.23.4", python = ">=3.11" },
]

It was changed in #444, but there didn't appear to be any justification for the change:

Image

Activity

  1. dhirschfeld commented on Feb 19, 2025

    @dhirschfeld
    ContributorAuthor

    AFAICT numpy isn't even a direct dependency - we import it only in the tests so it shouldn't be listed as a dependency of databricks-sql-connector.

    https://github.com/search?q=repo%3Adatabricks%2Fdatabricks-sql-python%20numpy&type=code

  2. self-assigned this
    on Feb 24, 2025
  3. akoshel commented on Feb 26, 2025

    @akoshel

    Hi
    databricks-sql-connector makes poetry builds fail due to PEP 517
    python-poetry/poetry#9351

  4. samikshya-db commented on Feb 27, 2025

    @samikshya-db
    Contributor

    @akoshel - Looks like the issue is closed. Can you open a new issue if your concerns are not addressed yet? [Maybe you can attach logs/ more context on the issue too]

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions