Skip to content

Add urllib3 as an explicit dependency #190

Closed

Description

@jacobus-herman

Hi!

Can you please add urllib3 as an explicit dependency to your package? I see that in the latest version, i.e. 2.9.0, you are using BaseHTTPResponse from urllib3 and this is only available in urllib3>=2.0.0. So can you either add this dependency or change the code to accommodate older versions of urllib3? :)

Activity

  1. susodapop commented on Aug 10, 2023

    @susodapop
    Contributor

    Thanks for opening this issue! Excellent catch.

  2. dthemg commented on Aug 18, 2023

    @dthemg

    An issue with this is that botocore requires urllib3 version 1, you can't have both installed:

    botocore 1.31.29 requires urllib3<1.27,>=1.25.4, but you have urllib3 2.0.4 which is incompatible
    
  3. susodapop commented on Aug 18, 2023

    @susodapop
    Contributor
  4. susodapop commented on Aug 18, 2023

    @susodapop
    Contributor

    Release 2.9.2 is now live on Pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions