Skip to content

auth_type parameter not optional #45

Open
Open
auth_type parameter not optional#45

Description

@jlenczuk-ckd
jlenczuk-ckd
opened on Apr 3, 2023

Hi,

I have updated databricks-sql-cli to version 0.3.0. Now my authentication details - host name, HTTP path and access token - fail when I pass them directly to the command line. I get the following error:
image

It seems that there is one argument missing, mainly the auth_type. However, the following code suggests that in case credentials key cannot be found in the conf file, apply_credentials_from_cfg should return 3 values. In other cases, it returns 4 values.

databricks-sql-cli/dbsqlcli/main.py

Line 61 in 345ca09

def apply_credentials_from_cfg(hostname, http_path, access_token, auth_type, cfg):

DBSQLCli class on the other hand, always tries to unpack 4 values coming from the apply_credentials_from_cfg function. This fails in my case, as I don't pass the auth_type and therefore I only have 3 values returned by the function.

databricks-sql-cli/dbsqlcli/main.py

Line 92 in 345ca09

hostname, http_path, access_token, auth_type = apply_credentials_from_cfg(

Did I understand it correctly and could you please provide any suggestions?

Activity

  1. naveen-arumugam commented on May 19, 2023

    @naveen-arumugam
    naveen-arumugam
    on May 19, 2023

    Facing the same issue; any suggestions?

  2. naveen-arumugam commented on May 19, 2023

    @naveen-arumugam
    naveen-arumugam
    on May 19, 2023

    It works if auth_type is added to the credentials check; not elegant, but works. Any suggestion?

    https://github.com/databricks/databricks-sql-cli/blob/345ca09bcf602b45755a6137af5e83f9e673272f/dbsqlcli/main.py#LL67C24-L67C24
    return hostname, http_path, access_token
    changing the above with auth_type makes the dbsqlcli to work
    return hostname, http_path, access_token, auth_type

    Also, this fails (suggesting that this file ~/.dbsqlcli/dbsqlclirc is ignored?)

    dbsqlcli -e "SELECT 1"
'NoneType' object has no attribute 'startswith'

    This works

    dbsqlcli -e "SELECT 1" \
--hostname "databricks_host" \
--http-path "databricks_http_path" \
--access-token "databricks_pat" 
1
1

  3. naveen-arumugam commented on May 19, 2023

    @naveen-arumugam
    naveen-arumugam
    on May 19, 2023

    do we've plan to add "-f" flag for SQL files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions