Skip to content

feat(mui): add form error alert - #1094

Merged
Hyperkid123 merged 1 commit into
data-driven-forms:masterfrom
rvsia:muiFormError
Jun 23, 2021
Merged

Hyperkid123 merged 1 commit into
data-driven-forms:masterfrom
rvsia:muiFormError

Conversation

@rvsia

@rvsia rvsia commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Part of #923

Description

Adds alert for form errors in MUI-mapper.

Screenshot 2021-06-23 at 16 01 09

Schema

validate={({something}) => {
    if(something?.length > 3) {
        return {[FormError]: 'too long'}
    }

    if(something) {
        return {[FormError]: 'too short'}
    }

    return {}
}}

@rvsia rvsia added enhancement New feature or request MUI MUI pull request labels Jun 23, 2021
@rvsia
rvsia requested a review from Hyperkid123 June 23, 2021 14:04
@DataDrivenFormsBot

Copy link
Copy Markdown

A new version (feat) will be released: v3.11.0 [DataDrivenFormsBot]

@codecov

codecov Bot commented Jun 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1094 (1c1210b) into master (de12613) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
+ Coverage   94.88%   94.89%   +0.01%     
==========================================
  Files         205      205              
  Lines        3497     3508      +11     
  Branches     1209     1212       +3     
==========================================
+ Hits         3318     3329      +11     
  Misses        179      179              
Impacted Files Coverage Δ
...omponent-mapper/src/form-template/form-template.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de12613...1c1210b. Read the comment docs.

@Hyperkid123
Hyperkid123 merged commit b10d3a3 into data-driven-forms:master Jun 23, 2021
@Hyperkid123

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.11.0 🎉

The release is available on

Demo can be found here!

@rvsia
rvsia deleted the muiFormError branch October 12, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request MUI MUI pull request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants