Skip to content

mui-component-mapper v4.1.0 not works with react19 #1506

Description

@RomanKosovnenko

Scope: mui-component-mapper

Description
When upgrading to react 19 with mui component mapper, there is an error:

npm error   react@"^19" from the root project
npm error   peer react@"^17.0.2 || ^18.0.0 || ^19.0.0" from @data-driven-forms/mui-component-mapper@4.1.0
npm error   node_modules/@data-driven-forms/mui-component-mapper
npm error     @data-driven-forms/mui-component-mapper@"^4.1.0" from the root project
npm error   7 more (@data-driven-forms/react-form-renderer, react-dom, ...)
npm error
npm error Could not resolve dependency:
npm error peer react@"^17.0.0 || ^18.0.0" from @mui/x-date-pickers@6.20.2
npm error node_modules/@mui/x-date-pickers
npm error   @mui/x-date-pickers@"^6.20.2" from the root project
npm error   peer @mui/x-date-pickers@"^5.0.1 || ^6.13.0" from @data-driven-forms/mui-component-mapper@4.1.0
npm error   node_modules/@data-driven-forms/mui-component-mapper
npm error     @data-driven-forms/mui-component-mapper@"^4.1.0" from the root project

Please, consider upgrading to at least v7

Schema

not relevant

Activity

  1. Hyperkid123 commented on May 6, 2025

    @Hyperkid123
    Member

    RIght, we need to bump the MUI packages as well.

  2. RomanKosovnenko commented on May 9, 2025

    @RomanKosovnenko
    Author

    Sorry to bother you, but this is quite critical for us. Do you have an approximate timeline for when it might be completed?

  3. Hyperkid123 commented on May 9, 2025

    @Hyperkid123
    Member

    I'll try to get at it today. I have other responsibilities though

  4. Hyperkid123 commented on May 9, 2025

    @Hyperkid123
    Member

    We are currently blocked on this: final-form/react-final-form#1046

    There was an effort to run on a custom form state manager. Though working, I do not have the capacity right now to ensure we have a stable release. If that PR does not get merged soon, I'll make a fork to increase the version range (the code works just fine). I'll see if I can find some colleagues to start contributing to the project.

  5. grellord commented on May 22, 2025

    @grellord

    Hi, do you have any updates on this? Currently this is a showstopper for us as well, since it's blocking us to use React 19. However, we understand that it might be time consuming on your side.

  6. Hyperkid123 commented on May 26, 2025

    @Hyperkid123
    Member

    Hello. I was on vacation finally. I think I'll have some time this week. Since this was merged: final-form/react-final-form#1046 I think it will make it way quicker than I hoped 🙂 .

  7. RomanKosovnenko commented on Jun 2, 2025

    @RomanKosovnenko
    Author

    @Hyperkid123 , I tried to do the upgrade myself.
    You can check the changes here: https://github.com/RomanKosovnenko/react-forms
    However, I have two failing tests - maybe you could take a look and help fix them.

  8. Hyperkid123 commented on Jun 3, 2025

    @Hyperkid123
    Member

    Hello @RomanKosovnenko. Unfortunately, it's not that simple, you will still have peer dependency issues with the react form renderer which has a dependency on the react final form, and that does support React 19. I've waited long enough, there is a version of the code with the correct peer dependency but was not released to npm. I'll be forking it and releasing it until the package is updated.

    I should have a new version today. I'll also be enabling a strict transitive dependency checking for this repository so we get properly notified.

    I have a branch already with most of the changes finished. The new version should be released today.

  9. Hyperkid123 commented on Jun 3, 2025

    @Hyperkid123
    Member

    @RomanKosovnenko I've created a draft PR with the necessary changes. As you can see its a bit large. Before we move forward with release automation, I want to wait for PF dependency to have a stable version that supports React 19. But I'll be releasing manually the renderer and MUI packages to unblock your effort.

    The tests and other validation for these packages is working well. There should be no regressions.

    I'll be marking the new releases as pre-release and share the version numbers here once I validate the dependency issues are resolved.

  10. Hyperkid123 commented on Jun 3, 2025

    @Hyperkid123
    Member

    @RomanKosovnenko you can use the following version:

    "@data-driven-forms/mui-component-mapper": "^4.2.0-0",
    "@data-driven-forms/react-form-renderer": "^4.2.0-0",
    

    Or install the packages with the @next tag. I have verified and the dependency conflicts are now resolved.

    I had to bump the mui version (the same versions you posted in your sample) so there might be some MUi differences. But I assume you should be able to deal with that. Let me know if you find anything strange with the default styling. I was going over the components but something may have slipped.

  11. RomanKosovnenko commented on Jun 17, 2025

    @RomanKosovnenko
    Author

    @Hyperkid123 Thanks a lot! We're currently testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions