Repository navigation
Clear framebuffer and reset cursor before drawing in field/Midi - #319
Open
atommarvel wants to merge 1 commit into
Open
atommarvel wants to merge 1 commit into
atommarvel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTICE
This is one of two PRs that provide a fix for #318
Beyond this section, this PR's body and the code changes were generated by Google Gemini from a conversation I had with it to get examples running on a Daisy Field + Seed3 seated in it. My day job is Android development so I currently don't have the knowledge to vet these changes deeply. The testing section of this PR body is true though, I did validate all daisy field examples worked with both seed3 and seed2.
Summary
field/Midi/Midi.cppcallshw.display.WriteString("Midi", Font_7x10, true); hw.display.Update();on startup without clearing the framebuffer(
Fill(false)) or setting the cursor position (SetCursor(0, 0)). This adds both calls prior toWriteString.(Companion
libDaisyfix: daisyaudio/libDaisy#732)Testing