Repository navigation
Add BIP44 derivation paths to Bitcoin Cash wallet restoration process - #330
Merged
Merged
Conversation
and make it the new default. we currently use slip44 (coinType 145) as the default
log failing derivePathType or type, as appropriate
slip44 is used by default
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## staging #330 +/- ##
===========================================
- Coverage 10.18% 10.11% -0.07%
===========================================
Files 514 517 +3
Lines 56342 56694 +352
===========================================
+ Hits 5736 5737 +1
- Misses 50606 50957 +351
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
do not comingle paths in later output selection by index
yo dawg
should re-enable if it can be fixed with the test mnemonic in hand
julian-CStack
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189
Semantically changes BIP44 -> SLIP44 (we use SLIP44 m/44/145 for BCH), adds m/44/0 as BIP44 derivation path, and checks both SLIP44 and BIP44 addresses for outputs during restoration.
SLIP44 addresses are still used as the default derivation path