Repository navigation
Desktop - #193
Merged
Merged
Desktop#193
Conversation
(cherry picked from commit a736c9a)
# Conflicts: # lib/pages/stack_privacy_calls.dart
…differences in a cleaner manner
# Conflicts: # lib/pages/stack_privacy_calls.dart
…ences with desktop modifications
Codecov Report
@@ Coverage Diff @@
## staging #193 +/- ##
===========================================
- Coverage 19.89% 18.77% -1.13%
===========================================
Files 378 394 +16
Lines 42300 43998 +1698
===========================================
- Hits 8416 8260 -156
- Misses 33884 35738 +1854
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vsnation
added a commit
to vsnation/campfire-beam
that referenced
this pull request
Oct 10, 2026
…es it Home's token list drew every Confidential Asset as two letters on a coloured circle, and showed the DEX liquidity tokens (cypherstack#175, cypherstack#192, cypherstack#193) as "Unnamed asset". Their names came only from each asset's metadata, which for a liquidity token is the contract's "Amm Liquidity Token 0-174-2", when it arrived at all. The web wallet now uses the desktop app's catalogue, ported line for line (lib/meta.js, lib/lookalike.js, lib/lp_tokens.js): - verified assets show Campfire's name, ticker and icon; - a liquidity token is named after its pool, "BEAM/FOMO LP", with "Pool share · 1% fee" under it and its pool's two icons. Only the DEX contract makes an asset a liquidity token: its pool list ships with the app (98 pools, cross-checked with the asset list) and every pool list the app reads adds newer pools, never a name; - any other asset shows its cleaned on-chain name with its number and the BEAM desktop wallet's generic icon for that number, and a copy of a verified asset gets the desktop's warning. Labels stay current: when metadata or a pool arrives, Home, Send, Swap, Activity and the approval sheets all show the new name. Money screens write an unverified ticker with its number ("5 PEPE cypherstack#94"), as the desktop does. The icons are the desktop app's files, byte for byte, bundled in the signed release and never fetched (img/assets, NOTICE.txt). A unit test pins each one here and in the desktop's folder. asset_parity.test.mjs compares the result with the desktop's own code for every asset on mainnet (203) and 61 edge cases, with and without metadata: no differences. tools/asset_parity/run.mjs refreshes that data. test/e2e/asset_icons.test.mjs checks the list in Chrome on a throwaway mainnet wallet. Documented in the project notes, section 3f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.