Skip to content

Add OpenAlias for Monero sends #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sneurlax wants to merge 5 commits into
base: staging
Choose a base branch
from
+1,155 −14
Draft

Add OpenAlias for Monero sends #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ad44e9
build(openalias): add the cs_openalias dependency
sneurlax Oct 16, 2026
29d0563
feat(openalias): resolve Monero OpenAlias recipients when previewing …
sneurlax Oct 16, 2026
b2da8ba
feat(tx): carry the OpenAlias a recipient was resolved from
sneurlax Oct 16, 2026
ba9f73f
feat(openalias): attach the resolved alias to the prepared transaction
sneurlax Oct 16, 2026
623d018
feat(confirm): show the OpenAlias above the recipient address
sneurlax Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions lib/pages/send_view/confirm_transaction_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,25 @@ class _ConfirmTransactionViewState
children: [
Text("Send $unit", style: STextStyles.pageTitleH1(context)),
const SizedBox(height: 12),
if (widget.txData.openAlias != null) ...[
RoundedWhiteContainer(
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Text(
"OpenAlias",
style: STextStyles.smallMed12(context),
),
const SizedBox(height: 4),
Text(
widget.txData.openAlias!,
style: STextStyles.itemSubtitle12(context),
),
],
),
),
const SizedBox(height: 12),
],
RoundedWhiteContainer(
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
Expand Down Expand Up @@ -1125,6 +1144,41 @@ class _ConfirmTransactionViewState
.extension<StackColors>()!
.background,
),
if (widget.txData.openAlias != null) ...[
Padding(
padding: const EdgeInsets.all(12),
child: Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(
"OpenAlias",
style: STextStyles.desktopTextExtraExtraSmall(
context,
),
),
const SizedBox(height: 2),
SelectableText(
widget.txData.openAlias!,
style:
STextStyles.desktopTextExtraExtraSmall(
context,
).copyWith(
color: Theme.of(context)
.extension<StackColors>()!
.textDark,
),
),
],
),
),
Container(
height: 1,
color: Theme.of(context)
.extension<StackColors>()!
.background,
),
],
Padding(
padding: const EdgeInsets.all(12),
child: Column(
Expand Down
66 changes: 64 additions & 2 deletions lib/pages/send_view/send_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import 'dart:async';
import 'dart:io';

import 'package:cs_openalias/cs_openalias.dart';
import 'package:decimal/decimal.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
Expand All @@ -30,6 +31,7 @@ import '../../providers/ui/fee_rate_type_state_provider.dart';
import '../../providers/ui/preview_tx_button_state_provider.dart';
import '../../providers/wallet/public_private_balance_state_provider.dart';
import '../../route_generator.dart';
import '../../services/openalias/open_alias_service.dart';
import '../../services/spark_names_service.dart';
import '../../themes/coin_icon_provider.dart';
import '../../themes/stack_colors.dart';
Expand Down Expand Up @@ -703,8 +705,9 @@ class _SendViewState extends ConsumerState<SendView> {
}
}

ref.read(pValidSendToAddress.notifier).state = wallet.cryptoCurrency
.validateAddress(address ?? "");
ref.read(pValidSendToAddress.notifier).state =
wallet.cryptoCurrency.validateAddress(address ?? "") ||
(coin is Monero && isOpenAlias(address ?? ""));
}
}

Expand Down Expand Up @@ -1018,11 +1021,69 @@ class _SendViewState extends ConsumerState<SendView> {
}
}

/// Replaces the OpenAlias in the address field with the address it resolves
/// to. Returns the alias, trimmed and lowercased, or null if the lookup
/// failed or was cancelled.
Future<String?> _resolveOpenAlias() async {
final alias = _address!.trim().toLowerCase();
CsOpenAliasOperation<CsOpenAliasRecipient>? operation;
bool cancelled = false;
unawaited(
showDialog<void>(
context: context,
useSafeArea: false,
barrierDismissible: false,
builder: (context) => BuildingTransactionDialog(
coin: coin,
isSpark: false,
onCancel: () {
cancelled = true;
operation?.cancel();
Navigator.of(context).pop();
},
),
),
);
try {
operation = ref
.read(pOpenAliasService)
.lookup(_address!, isValidAddress: coin.validateAddress);
final address = (await operation.result).address;
if (cancelled || !mounted) return null;
Navigator.of(context, rootNavigator: true).pop();
sendToController.text = address;
_address = address;
_setValidAddressProviders(_address);
return alias;
} catch (e, s) {
if (cancelled || !mounted) return null;
Logging.instance.w("OpenAlias lookup failed", error: e, stackTrace: s);
Navigator.of(context, rootNavigator: true).pop();
unawaited(
showDialog<void>(
context: context,
builder: (context) => StackOkDialog(
title: openAliasLookupFailedTitle,
message: e is CsOpenAliasException ? e.userMessage : e.toString(),
),
),
);
return null;
}
}

Future<void> _previewTransaction() async {
// wait for keyboard to disappear
FocusScope.of(context).unfocus();
await Future<void>.delayed(const Duration(milliseconds: 100));
final wallet = ref.read(pWallets).getWallet(walletId);
String? openAlias;
if (coin is Monero &&
!coin.validateAddress(_address ?? "") &&
isOpenAlias(_address ?? "")) {
openAlias = await _resolveOpenAlias();
if (openAlias == null || !mounted) return;
}

final Amount amount = ref.read(pSendAmount)!;
final Amount availableBalance;
Expand Down Expand Up @@ -1274,6 +1335,7 @@ class _SendViewState extends ConsumerState<SendView> {
)!,
),
],
openAlias: openAlias,
memo: memo,
feeRateType: feeRateType,
satsPerVByte: satsPerVByte,
Expand Down
74 changes: 72 additions & 2 deletions lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import 'dart:async';

import 'package:cs_openalias/cs_openalias.dart';
import 'package:decimal/decimal.dart';
import 'package:dropdown_button2/dropdown_button2.dart';
import 'package:flutter/material.dart';
Expand Down Expand Up @@ -37,6 +38,7 @@ import '../../../../providers/ui/fee_rate_type_state_provider.dart';
import '../../../../providers/ui/preview_tx_button_state_provider.dart';
import '../../../../providers/wallet/desktop_fee_providers.dart';
import '../../../../providers/wallet/public_private_balance_state_provider.dart';
import '../../../../services/openalias/open_alias_service.dart';
import '../../../../services/spark_names_service.dart';
import '../../../../themes/stack_colors.dart';
import '../../../../utilities/address_utils.dart';
Expand Down Expand Up @@ -73,6 +75,7 @@ import '../../../../widgets/desktop/desktop_dialog_close_button.dart';
import '../../../../widgets/desktop/primary_button.dart';
import '../../../../widgets/desktop/qr_code_scanner_dialog.dart';
import '../../../../widgets/desktop/secondary_button.dart';
import '../../../../widgets/desktop/simple_desktop_dialog.dart';
import '../../../../widgets/dialogs/firo_exchange_address_dialog.dart';
import '../../../../widgets/epic_txs_method_toggle.dart';
import '../../../../widgets/eth_fee_form.dart';
Expand Down Expand Up @@ -437,12 +440,77 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
}
}

/// Replaces the OpenAlias in the address field with the address it resolves
/// to. Returns the alias, trimmed and lowercased, or null if the lookup
/// failed or was cancelled.
Future<String?> _resolveOpenAlias() async {
final alias = _address!.trim().toLowerCase();
CsOpenAliasOperation<CsOpenAliasRecipient>? operation;
bool cancelled = false;
unawaited(
showDialog<void>(
context: context,
useSafeArea: false,
barrierDismissible: false,
builder: (context) => DesktopDialog(
maxWidth: 400,
maxHeight: double.infinity,
child: Padding(
padding: const EdgeInsets.all(32),
child: BuildingTransactionDialog(
coin: coin,
isSpark: false,
onCancel: () {
cancelled = true;
operation?.cancel();
Navigator.of(context).pop();
},
),
),
),
),
);
try {
operation = ref
.read(pOpenAliasService)
.lookup(_address!, isValidAddress: coin.validateAddress);
final address = (await operation.result).address;
if (cancelled || !mounted) return null;
Navigator.of(context, rootNavigator: true).pop();
sendToController.text = address;
_address = address;
_setValidAddressProviders(_address);
return alias;
} catch (e, s) {
if (cancelled || !mounted) return null;
Logging.instance.w("OpenAlias lookup failed", error: e, stackTrace: s);
Navigator.of(context, rootNavigator: true).pop();
unawaited(
showDialog<void>(
context: context,
builder: (context) => SimpleDesktopDialog(
title: openAliasLookupFailedTitle,
message: e is CsOpenAliasException ? e.userMessage : e.toString(),
),
),
);
return null;
}
}

Future<void> previewSend() async {
final nonceInput = _nonceInput;
if (!nonceInput.isValid) return;
final nonce = nonceInput.value;

final wallet = ref.read(pWallets).getWallet(walletId);
String? openAlias;
if (coin is Monero &&
!coin.validateAddress(_address ?? "") &&
isOpenAlias(_address ?? "")) {
openAlias = await _resolveOpenAlias();
if (openAlias == null || !mounted) return;
}

// Handle MWC slatepack transactions directly.
if (isMimblewimblecoin && ref.read(pIsSlatepack(widget.walletId))) {
Expand Down Expand Up @@ -743,6 +811,7 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
)!,
),
],
openAlias: openAlias,
memo: memo,
feeRateType: feeRateType,
satsPerVByte: satsPerVByte,
Expand Down Expand Up @@ -1021,8 +1090,9 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
}
}

ref.read(pValidSendToAddress.notifier).state = wallet.cryptoCurrency
.validateAddress(address ?? "");
ref.read(pValidSendToAddress.notifier).state =
wallet.cryptoCurrency.validateAddress(address ?? "") ||
(coin is Monero && isOpenAlias(address ?? ""));
}
}

Expand Down
Loading
Loading