Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1380 +/- ##
===========================================
+ Coverage 7.85% 9.64% +1.78%
===========================================
Files 1125 1129 +4
Lines 112820 113516 +696
===========================================
+ Hits 8866 10949 +2083
+ Misses 103954 102567 -1387 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julian-CStack
requested changes
May 27, 2026
julian-CStack
left a comment
julian-CStack
left a comment
Collaborator
There was a problem hiding this comment.
I agree this could be improved. But I do not thick these requested changes are the solution.
I've talked to someone before about this exact spot but I cannot remember who.
Member
Author
sneurlax
force-pushed
the
fix/logger-recursion
branch
from
August 21, 2026 00:51
1cb505a to
7b5f665
Compare
Member
Author
|
OK, errors are typically written to
|
sneurlax
force-pushed
the
fix/logger-recursion
branch
from
August 25, 2026 00:03
b526b92 to
9eb882e
Compare
When sending to the logger isolate fails, log() reports it through t(), which sends again. If the port is gone every send fails, so log -> t -> log recursed until the stack overflowed. Report the failure once; if that fails too, print the original entry and the error instead.
sneurlax
force-pushed
the
fix/logger-recursion
branch
from
October 13, 2026 16:07
9eb882e to
2e675d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.