Repository navigation
Conversation
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
MySQL rejects an AUTO_INCREMENT column without a key (error 1075), so adding one to an existing table and creating its index afterwards always failed. The column and the indexes covering it now go into a single ALTER TABLE; a column with no index fails with the same SchemaException as on table creation, before the column is added. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #279 +/- ##
=========================================
Coverage 95.72% 95.73%
- Complexity 2246 2252 +6
=========================================
Files 142 142
Lines 6384 6397 +13
=========================================
+ Hits 6111 6124 +13
Misses 273 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
autoIncrement: truecolumn added to an existing MySQL table is now created in the sameALTER TABLEas the indexes that cover it. Before, the index was created afterwards and the column failed with error 1075.SchemaExceptionas on table creation (fix(MySQL): keep auto-increment columns out of the primary key #275), before the column is added.Review notes
ALTER … CHANGE) together with a new index still runs the index afterwards. That path is unchanged here.Checklist