Repository navigation
Conversation
The GB postcode format only matched the compact form, so "SW1A 1AA" returned 422 invalid_postcode and checkout showed "Sorry, we can't deliver to this address." Remove whitespace and upper-case the postcode before checking it against the country format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Before and after for
Screenshots attached: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes ENG-412: checkout rejected UK postcodes typed with a space.
Cause: the GB format in
shipping.mjs(/^[A-Z]{1,2}\d[A-Z\d]?\d[A-Z]{2}$/) has no space, soPOST /api/shipping-rateswithSW1A 1AAreturned 422invalid_postcode, and the shipping step showed "Sorry, we can't deliver to this address."Fix:
quoteShippingremoves whitespace and upper-cases the postcode before checking it.SW1A 1AAandsw1a1aanow get delivery options; a partial postcode such asSW1Ais still rejected.Verified:
curlagainst the local shop:SW1A 1AAreturns both GB rates,SW1Areturns 422.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.