Skip to content

fix(cubejs-questdb-driver): unsupported HAVING clause - #10285

Merged
ovr merged 1 commit into
cube-js:masterfrom
puzpuzpuz:questdb_fix_having_clause
May 29, 2026
Merged

ovr merged 1 commit into
cube-js:masterfrom
puzpuzpuz:questdb_fix_having_clause

Conversation

@puzpuzpuz

Copy link
Copy Markdown
Contributor

Fixes #10148

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@puzpuzpuz
puzpuzpuz requested review from a team as code owners January 5, 2026 14:51
@github-actions github-actions Bot added driver:questdb javascript Pull requests that update Javascript code data source driver pr:community Contribution from Cube.js community members. labels Jan 5, 2026
@puzpuzpuz

Copy link
Copy Markdown
Contributor Author

The failed tests look unrelated unless I'm missing something.

@KSDaemon KSDaemon removed their assignment Jan 16, 2026
@puzpuzpuz

Copy link
Copy Markdown
Contributor Author

@igorlukanin could you review this one? We have a user who's waiting for this fix.

@puzpuzpuz

Copy link
Copy Markdown
Contributor Author

@waralexrom thanks for the review! Any chances that the fix goes into one of the upcoming releases? @peterklingelhofer is waiting for this fix for a while now.

@peterklingelhofer

Copy link
Copy Markdown
Contributor

@waralexrom Any chance we can include this in an upcoming release? This would help us clean up our Cube schemas considerably if merged. Thank you.

@ovr
ovr force-pushed the questdb_fix_having_clause branch from f13e0fd to d10dfbf Compare May 29, 2026 10:32
@ovr

ovr commented May 29, 2026

Copy link
Copy Markdown
Member

/bot-deep-review

@ovr
ovr merged commit 632620d into cube-js:master May 29, 2026
71 of 73 checks passed
@puzpuzpuz
puzpuzpuz deleted the questdb_fix_having_clause branch May 29, 2026 11:00
@puzpuzpuz

Copy link
Copy Markdown
Contributor Author

@ovr thanks!

This branch was successfully deployed

1 active deployment
Preview — d10dfbfa Deployed May 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver driver:questdb javascript Pull requests that update Javascript code pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greater than, less than, etc, not supported by measures with QuestDB data source

5 participants