Reminders Pages UI [1/2] Added Main and Fixed Workout & Capacity Reminder Screens by clin0595 · Pull Request #134 · cuappdev/uplift-android

clin0595 · 2026-11-10T22:01:32Z

Overview

Implemented the Main Reminder page in the settings, edited the Workout Reminder Page and the Capacity Reminder page, and added navigation to them.

Changes Made

Added Reminder Option into Settings
Implemented UI for the Main Reminder Page
Edited Workout Reminders UI to save data after hitting done and deleted slider
Implemented Workout Reminders View Model (data stored locally in DatastoreRepository.kt)
Implemented navigation for Workout Reminders and Capacity Reminders

Test Coverage

These features can be manually tested.
Navigate to Profile page, then navigate to Settings page
Click on Reminders option to access the Workout Reminders page and the Capacity Reminders page

Next Steps

The Class Reminders Screen will be implemented in the next PR of this stack.

Related PRs or Issues

Reminders Pages UI [2/2] Added Class Reminders Screen https://github.com/cuappdev/uplift-android/pull/135

Screenshots

Workout Reminders Screen and Capacity Reminders Screen

Screen_recording_20261110_163223.mp4

https://www.figma.com/design/SJZ7i0N1Ly5PORfkJh7qXH/Uplift-SP26?node-id=6195-14550&t=iZS2IBggIzTXZNLn-1

Workout Reminders UI from Figma for comparison

…actored localized SettingsOption component within SettingsScreen.kt to be a globalized PageOption component.

…navigation to ClassReminder page and Workout Page.

…kt, which accepts a string as the title. Implemented ClassReminder UI (untoggled).

…nd DescriptionReminderSwitch.kt

…have states in the viewmodel.

# Conflicts: # app/src/main/java/com/cornellappdev/uplift/ui/MainNavigationWrapper.kt # app/src/main/java/com/cornellappdev/uplift/ui/components/reminders/goalsetting/GoalSettingHeader.kt # app/src/main/java/com/cornellappdev/uplift/ui/screens/reminders/WorkoutRemindersScreen.kt

coderabbitai · 2026-11-10T22:01:38Z

Important

Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: bf56e8f6-5c77-45e8-8f1d-9a785f37e72b

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

caleb-bit

Nice work. Left some minor comments.

caleb-bit · 2026-11-11T20:17:12Z

    val CAPACITY_REMINDERS_SELECTED_DAYS = stringSetPreferencesKey("capacityRemindersSelectedDays")
    val CAPACITY_REMINDERS_SELECTED_GYMS = stringSetPreferencesKey("capacityRemindersSelectedGyms")
    val CAPACITY_REMINDERS_TUTORIAL_SHOWN = booleanPreferencesKey("capacityReminderTutorialShown")
+    val WORKOUT_REMINDERS_TOGGLE = booleanPreferencesKey("workoutRemindersToggle")


Unused. Do we need this?

caleb-bit · 2026-11-11T20:21:07Z

        }.firstOrNull()
    }

+    suspend fun getPreferencesSnapshot(): Preferences {


Should we just be exposing all of the data like this? The point of this DataStoreRepository abstraction should be to abstract out this Preferences object. We should always try to maintain narrow interfaces.

caleb-bit · 2026-11-11T20:21:32Z

Can you format this file?

caleb-bit · 2026-11-11T20:24:04Z

+            lineHeight = 14.63.sp,
+            letterSpacing = 0.3.sp,


Could you double check these values with Figma? These values seem abnormal.

caleb-bit · 2026-11-11T20:24:41Z

+import androidx.compose.material.Icon
+import androidx.compose.material.Surface
+import androidx.compose.material.Text


We should use Material 3 components.

caleb-bit · 2026-11-11T20:25:58Z

                ) {
-                    CapacityReminderSwitch(
+                    DescriptionReminderSwitch(
+                        text = "Capacity Reminders",


caleb-bit · 2026-11-11T20:28:08Z

Can you format this file? Could you also extract strings?

caleb-bit · 2026-11-11T20:31:55Z

 /**
- * @param reminders: list of reminders
+ * @param uiState: UI state containing reminders, goal value, dialog state
 * @param goalValue: the value of the goal slider
 * @param onRemindersChange: callback for when reminders are changed
- * @param onGoalValueChange: callback for when the goal slider value is changed
+ * @param onSelectedReminderChange: callback for when selected reminder changes
+ * @param onAddNewReminderStateChange: callback for when adding reminder state changes
+ * @param onDeleteDialogOpenChange: callback for when delete dialog open state changes
+ * @param onDeleteConfirm: callback for when delete reminder is confirmed
 * @param onBackClick: callback for when the back button is clicked
 * @param isOnboarding: whether the user is in onboarding
 * @param onNext: callback for when the next button is clicked


This documentation seems unidiomatic with respect to the rest of the repo and largely redundant since the variable names are fairly self-documenting. We could probably just remove.

caleb-bit · 2026-11-11T20:33:06Z

                onConfirm = {
-                    selectedReminder?.let { reminder ->
-                        onRemindersChange(reminders.filter { it != reminder })
-                    }
-                    onDeleteDialogOpenChange(false)
-                    onSelectedReminderChange(null)
-                    onAddNewReminderStateChange(false)
+                    onDeleteConfirm()
                },


Nit: Nicer to just write onConfirm = onDeleteConfirm.

caleb-bit · 2026-11-11T20:36:47Z

+        }
+    }
+
+    private fun saveRemindersToDataStore(reminders: List<Reminder>) {


Does it make more sense for this to be a DatastoreRepository function?

clin0595 added 14 commits October 28, 2026 12:52

Added bell icon and added new reminders option in settings page.

1536bef

Initialized ClassReminderScreen.kt and ClassReminderViewModel.kt. Ref…

86e8d1a

…actored localized SettingsOption component within SettingsScreen.kt to be a globalized PageOption component.

Refactored MainReminderScreen to use new PageOption component. Added …

4b563d9

…navigation to ClassReminder page and Workout Page.

Refactored CapacityReminderSwitch.kt to be DescriptionReminderSwitch.…

c1f35ab

…kt, which accepts a string as the title. Implemented ClassReminder UI (untoggled).

Implemented UI of ClassReminderScreen.kt, added RadioCheckButton.kt a…

aa0a507

…nd DescriptionReminderSwitch.kt

Added error handling for minutes input in ClassReminderScreen.kt

8ee6e8e

Refactored ClassRemindersScreen.kt and ClassRemindersViewModel.kt to …

566643a

…have states in the viewmodel.

Added ClassReminders to DatascoreRepository

73518f8

Merged current code from Main to this branch.

56bce06

Fixed ClassRemindersScreen.kt's Preview to include error handling.

2483326

Added documentation comments for Reminder screens.

f8de9ff

Reorganized reminders and add main and workout reminders screens

4d97d54

Reorganize reminders and add main and workout reminders screens

4ed3398

clin0595 mentioned this pull request Nov 10, 2026

Reminders Pages UI [1/2] Added Main and Fixed Workout & Capacity Reminder Screens #133

Closed

clin0595 added this pull request to stack #136 November 10, 2026 22:16

clin0595 requested a review from caleb-bit November 10, 2026 22:21

caleb-bit requested changes Nov 11, 2026

View reviewed changes

Navigation Menu

Repository navigation

Reminders Pages UI [1/2] Added Main and Fixed Workout & Capacity Reminder Screens - #134

Reminders Pages UI [1/2] Added Main and Fixed Workout & Capacity Reminder Screens#134
clin0595 wants to merge 14 commits into
mainfrom
cinnie/reminder-screens

clin0595 commented Nov 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 10, 2026 •

edited

Loading

Uh oh!

caleb-bit left a comment

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

caleb-bit Nov 11, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

clin0595 commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes Made

Test Coverage

Next Steps

Related PRs or Issues

Screenshots

Uh oh!

coderabbitai Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

caleb-bit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clin0595 commented Nov 10, 2026 •

edited

Loading

coderabbitai Bot commented Nov 10, 2026 •

edited

Loading