Skip to content

Reminders Pages UI [2/2] Added Class Reminders Screen - #130

Closed
clin0595 wants to merge 1 commit into
cinnie/reminder-screensfrom
cinnie/settings-reminders
Closed

clin0595 wants to merge 1 commit into
cinnie/reminder-screensfrom
cinnie/settings-reminders

Conversation

@clin0595

@clin0595 clin0595 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Implemented UI of the reminder pages accessible from settings.

Changes Made

  • Added Reminder Option into Settings

  • Implemented UI for the Main Reminder Page

  • Implemented Class Reminders UI

  • Implemented Class Reminders View Model (data stored locally in DatastoreRepository.kt)

  • Edited Workout Reminders UI to save data after hitting done and deleted slider

  • Implemented Workout Reminders View Model (data stored locally in DatastoreRepository.kt)

  • Implemented navigation for all pages

Test Coverage

These features can be manually tested.
Navigate to Profile page, then navigate to Settings page
Click on Reminders option to access the 3 Reminder pages

Next Steps

Implement notifications for these reminders

Screenshots

Testing Video
Screen_recording_20261109_193840.mp4

https://www.figma.com/design/SJZ7i0N1Ly5PORfkJh7qXH/Uplift-SP26?node-id=6195-14550&t=iZS2IBggIzTXZNLn-1

Class Reminders UI from Figma Class Reminder - Error State (1)
Workout Reminders UI from Figma Set Goals - End (1)

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a671d8f5-2cea-4537-94b2-6d6853c22cb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@clin0595
clin0595 marked this pull request as ready for review November 5, 2026 15:16
@clin0595
clin0595 requested a review from caleb-bit November 5, 2026 15:16

@caleb-bit caleb-bit left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question about the demo, is it expected for the default custom time to show 99 minutes? It seems odd that that would be the case. Also, it would be helpful if you provided the Figma link to the components you're implementing in the PR to help me quickly cross-check.

@clin0595

Copy link
Copy Markdown
Contributor Author

Just a quick question about the demo, is it expected for the default custom time to show 99 minutes? It seems odd that that would be the case. Also, it would be helpful if you provided the Figma link to the components you're implementing in the PR to help me quickly cross-check.

I've added the Figma link to the components (they should all be in that link). Also the 99 minutes was from my testing before that I forgot to change when recording the video. I have updated the video.

@clin0595
clin0595 requested a review from caleb-bit November 10, 2026 00:44

@caleb-bit caleb-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this PR up? 1000+ lines is generally a sign that the PR is too long.

@clin0595
clin0595 changed the base branch from main to reminders-1-main November 10, 2026 21:58
@clin0595 clin0595 changed the title Reminder Pages UI in Settings Reminders Pages UI [2/2] Added Class Reminders Screen Nov 10, 2026
@clin0595
clin0595 deleted the branch reminders-1-main November 10, 2026 22:02
@clin0595 clin0595 closed this Nov 10, 2026
@clin0595 clin0595 reopened this Nov 10, 2026
@clin0595
clin0595 changed the base branch from reminders-1-main to cinnie/reminder-screens November 10, 2026 22:05
@clin0595 clin0595 closed this Nov 10, 2026
@clin0595

Copy link
Copy Markdown
Contributor Author

Replaced by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants