Repository navigation
Conversation
A row without a parent or result line still labeled its empty number cell "Parent line number" or "Result line number", though there was no number for the tooltip to explain. Keep the tooltip only on cells that show a number, which removes about 3% of a large report's size.
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves source content, numbering, and layout, with no unresolved issues.
0 open findings
What changed in this PR
Removes unnecessary tooltips from empty line-number cells in HTML reports, reducing output size without changing numbering or layout.
Changes:
- Keeps line-number tooltips only on populated cells.
- Updates both sample reports to match.
| File | Description |
|---|---|
| src/html.c | Omits tooltip attributes for empty number cells. |
| samples/indentation.html | Updates sample tooltip markup. |
| samples/arguments.html | Updates sample tooltip markup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A row without a parent or result line still labeled its empty number cell "Parent line number" or "Result line number", though there was no number for the tooltip to explain. Keep the tooltip only on cells that show a number, which removes about 3% of a large report's size.