Repository navigation
Conversation
A gap cell holds no source line, yet it carried the source-side class and a data-side attribute that only style source text. Emit a gap with just its class and tooltip, and drop the stylesheet rule that undid the source-cell background for gaps. This removes about 3% of a large report's size.
There was a problem hiding this comment.
🟢 Approval recommended
The localized changes preserve gap layout and checker alignment, with no unresolved issues.
0 open findings
What changed in this PR
Simplifies gap-cell markup in HTML comparison reports to reduce output size without changing source-cell rendering.
Changes:
- Removes source-only classes and attributes from gap cells.
- Deletes the redundant gap background rule.
- Updates the HTML checker and sample reports.
| File | Description |
|---|---|
| tests/check-highlight.py | Recognizes gap cells independently of source cells. |
| src/html.css | Removes the redundant gap background override. |
| src/html.c | Emits minimal gap-cell markup. |
| samples/indentation.html | Updates embedded styles and gap markup. |
| samples/arguments.html | Updates embedded styles and gap markup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A gap cell holds no source line, yet it carried the source-side class and a data-side attribute that only style source text. Emit a gap with just its class and tooltip, and drop the stylesheet rule that undid the source-cell background for gaps. This removes about 3% of a large report's size.