Repository navigation
Conversation
Every source row carried an id="row-N" attribute, but neither the viewer's navigation nor its styles refer to it. Remove the attribute and its counter, which saves about 2% of a large report's size.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, with no remaining consumers of the removed identifiers or unresolved issues.
0 open findings
What changed in this PR
Reduces HTML report size by removing unused source-row identifiers without changing source content or viewer navigation.
Changes:
- Removes the row counter and
id="row-N"attributes from HTML generation. - Updates both sample reports to match.
| File | Description |
|---|---|
| src/html.c | Removes row identifiers and their counter. |
| samples/indentation.html | Removes identifiers from sample rows. |
| samples/arguments.html | Removes identifiers from sample rows. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every source row carried an id="row-N" attribute, but neither the viewer's navigation nor its styles refer to it. Remove the attribute and its counter, which saves about 2% of a large report's size.