Repository navigation
Conversation
Every source cell carried a data-newline attribute, yet nearly all lines end in a newline and the viewer never reads the value. Write the attribute only for a line without its final newline, which removes about 3% of a large report's size.
There was a problem hiding this comment.
🟢 Approval recommended
The narrow output change preserves missing-newline information without affecting viewer behavior or existing consumers.
0 open findings
What changed in this PR
Reduces generated HTML report size by recording newline metadata only when a source line lacks its final newline.
Changes:
- Omits redundant
data-newline="yes"attributes while preserving missing-newline markers. - Updates both sample reports to match the renderer output.
| File | Description |
|---|---|
| src/html.c | Emits newline metadata only for missing final newlines. |
| samples/indentation.html | Removes redundant affirmative newline attributes. |
| samples/arguments.html | Removes redundant affirmative newline attributes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every source cell carried a data-newline attribute, yet nearly all lines end in a newline and the viewer never reads the value. Write the attribute only for a line without its final newline, which removes about 3% of a large report's size.